Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 337396

Summary: Synchronize View opens compare view with wrong order
Product: [Technology] EGit Reporter: Gunnar Wagenknecht <gunnar>
Component: UIAssignee: Dariusz Luksza <dariusz.luksza>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: caniszczyk, dariusz.luksza, stefan.lay
Version: 0.11   
Target Milestone: 0.12-M1   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
screenshot demonstrating the issue none

Description Gunnar Wagenknecht CLA 2011-02-17 03:17:27 EST
Created attachment 189155 [details]
screenshot demonstrating the issue

Select and incoming change set in the Synchronize View and double click on the file with incoming changes. As a result the compare view opens but with the wrong input order, i.e. the compare view shows the "remote" file on the left and the "local" file on the right. This is unexpected and is usually the other way around. As a result, the structure compare also shows the change as outgoing although the change set is incoming.

It would also be nice if the title above the content could say a little bit more what is "local" and what is "remote". Commit ids don't memorize as easy as a branch name (or something like "workspace", "HEAD", etc.).
Comment 1 Dariusz Luksza CLA 2011-02-21 16:02:13 EST
I'll inspect this issue with compare view.

Regardless version naming, I think that we can't do anything with it because in change set model we are comparing commit against it parent therefore we cannot name in a different way then using id's.  Maybe we can use part of first commit line but IMHO this would be less readable.
Comment 2 Dariusz Luksza CLA 2011-02-21 17:00:39 EST
I think that I solve this issue, this change should fix it:
http://egit.eclipse.org/r/2561
Comment 3 Chris Aniszczyk CLA 2011-02-23 12:43:35 EST
Fixed in master.

Thanks guys.