Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 337364

Summary:	NPE In synchronize view
Product:	[Technology] EGit	Reporter:	Tomi Pakarinen <tomi.pakarinen>
Component:	UI	Assignee:	Dariusz Luksza <dariusz.luksza>
Status:	CLOSED WORKSFORME	QA Contact:
Severity:	major
Priority:	P3	CC:	dariusz.luksza, stefan.lay
Version:	0.11
Target Milestone:	---
Hardware:	Macintosh
OS:	Mac OS X - Carbon (unsup.)
Whiteboard:

Description Tomi Pakarinen

2011-02-16 16:26:55 EST

When i tried to browse project in synchronize view. i got error and sub tree wasn't displayed. Version was actually 0.11.1, but i wasn't available.

java.lang.NullPointerException
	at org.eclipse.egit.ui.internal.synchronize.model.GitModelCommit.equals(GitModelCommit.java:103)
	at org.eclipse.egit.ui.internal.synchronize.model.GitModelTree.equals(GitModelTree.java:97)
	at org.eclipse.egit.ui.internal.synchronize.model.GitModelCacheTree.equals(GitModelCacheTree.java:55)
	at org.eclipse.jface.viewers.CustomHashtable.keyEquals(CustomHashtable.java:275)
	at org.eclipse.jface.viewers.CustomHashtable.get(CustomHashtable.java:239)
	at org.eclipse.jface.viewers.StructuredViewer.mapElement(StructuredViewer.java:1295)
	at org.eclipse.jface.viewers.TreeViewer.mapElement(TreeViewer.java:760)
	at org.eclipse.ui.navigator.CommonViewer.mapElement(CommonViewer.java:416)
	at org.eclipse.jface.viewers.StructuredViewer.associate(StructuredViewer.java:616)
	at org.eclipse.jface.viewers.AbstractTreeViewer.associate(AbstractTreeViewer.java:703)
	at org.eclipse.jface.viewers.AbstractTreeViewer.doUpdateItem(AbstractTreeViewer.java:1003)
	at org.eclipse.jface.viewers.StructuredViewer$UpdateItemSafeRunnable.run(StructuredViewer.java:481)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:49)
	at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:175)
	at org.eclipse.jface.viewers.StructuredViewer.updateItem(StructuredViewer.java:2141)
	at org.eclipse.jface.viewers.AbstractTreeViewer.createTreeItem(AbstractTreeViewer.java:829)
	at org.eclipse.jface.viewers.AbstractTreeViewer$1.run(AbstractTreeViewer.java:804)
	at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70)
	at org.eclipse.jface.viewers.AbstractTreeViewer.createChildren(AbstractTreeViewer.java:778)
	at org.eclipse.jface.viewers.TreeViewer.createChildren(TreeViewer.java:644)
	at org.eclipse.jface.viewers.AbstractTreeViewer.createChildren(AbstractTreeViewer.java:749)
	at org.eclipse.jface.viewers.AbstractTreeViewer.handleTreeExpand(AbstractTreeViewer.java:1444)
	at org.eclipse.jface.viewers.TreeViewer.handleTreeExpand(TreeViewer.java:952)
	at org.eclipse.jface.viewers.AbstractTreeViewer$4.treeExpanded(AbstractTreeViewer.java:1455)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:132)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:3776)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1367)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1390)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1375)
	at org.eclipse.swt.widgets.TreeItem.sendExpand(TreeItem.java:1024)
	at org.eclipse.swt.widgets.Tree.expandItem_expandChildren(Tree.java:1186)
	at org.eclipse.swt.widgets.Display.windowProc(Display.java:5183)
	at org.eclipse.swt.internal.cocoa.OS.objc_msgSendSuper(Native Method)
	at org.eclipse.swt.widgets.Widget.callSuper(Widget.java:220)
	at org.eclipse.swt.widgets.Widget.mouseDownSuper(Widget.java:1025)
	at org.eclipse.swt.widgets.Tree.mouseDownSuper(Tree.java:1974)
	at org.eclipse.swt.widgets.Widget.mouseDown(Widget.java:1021)
	at org.eclipse.swt.widgets.Control.mouseDown(Control.java:2258)
	at org.eclipse.swt.widgets.Tree.mouseDown(Tree.java:1942)
	at org.eclipse.swt.widgets.Display.windowProc(Display.java:4976)
	at org.eclipse.swt.internal.cocoa.OS.objc_msgSendSuper(Native Method)
	at org.eclipse.swt.widgets.Widget.callSuper(Widget.java:220)
	at org.eclipse.swt.widgets.Widget.windowSendEvent(Widget.java:1943)
	at org.eclipse.swt.widgets.Shell.windowSendEvent(Shell.java:2025)
	at org.eclipse.swt.widgets.Display.windowProc(Display.java:5040)
	at org.eclipse.swt.internal.cocoa.OS.objc_msgSendSuper(Native Method)
	at org.eclipse.swt.widgets.Display.applicationSendEvent(Display.java:4582)
	at org.eclipse.swt.widgets.Display.applicationProc(Display.java:4659)
	at org.eclipse.swt.internal.cocoa.OS.objc_msgSend(Native Method)
	at org.eclipse.swt.internal.cocoa.NSApplication.sendEvent(NSApplication.java:115)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3274)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2640)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2604)
	at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2438)
	at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:671)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:664)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:115)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:369)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:619)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:574)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1407)

Comment 1 Dariusz Luksza

2011-02-24 19:36:09 EST

(In reply to comment #0)
> When i tried to browse project in synchronize view. i got error and sub tree
> wasn't displayed. Version was actually 0.11.1, but i wasn't available.
> 
> java.lang.NullPointerException
>     at
> org.eclipse.egit.ui.internal.synchronize.model.GitModelCommit.equals(GitModelCommit.java:103)
>     at
> org.eclipse.egit.ui.internal.synchronize.model.GitModelTree.equals(GitModelTree.java:97)
>     at
> org.eclipse.egit.ui.internal.synchronize.model.GitModelCacheTree.equals(GitModelCacheTree.java:55)

I think that this issue should be also fixed with commit cc1b5fc23521ad93415f0a176dec3d8b9697dfcb

Could you check this same scenario using latest nightly build?

Comment 2 Tomi Pakarinen

2011-02-27 17:18:45 EST

Yes, works fine in nightly build (0.12.0.201102261648)

Comment 3 Dariusz Luksza

2011-02-27 17:29:30 EST

(In reply to comment #2)
> Yes, works fine in nightly build (0.12.0.201102261648)

Thank you for checking ;)