Bugzilla – Full Text Bug Listing
| Summary: | Many "NLS unused message" messages are logged into the .log file | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [WebTools] JSDT | Reporter: | Kit Lo <kitlo> | ||||||||
| Component: | Debug | Assignee: | Michael Rennie <Michael_Rennie> | ||||||||
| Status: | RESOLVED FIXED | QA Contact: | Michael Rennie <Michael_Rennie> | ||||||||
| Severity: | normal | ||||||||||
| Priority: | P3 | CC: | ccc, cpuidle, thatnitind | ||||||||
| Version: | 3.3 | ||||||||||
| Target Milestone: | 3.2.4 | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Windows XP | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
Using the code from the 3.2.2 and 3.2.3 branches I cannot reproduce these log entries - all entries match up in the messages.properties and Messages.java. I will grab the build mentioned and check it. *** Bug 338378 has been marked as a duplicate of this bug. *** Created attachment 189974 [details]
fix
Ran the tooling to find broken NLS messages, the patch contains the removals of the unused messages.
Created attachment 189976 [details]
fix for 3.2.4
This is the patch for the 3.2.x branch. When I compared the changes to the missing NLS messages in the attached log I found many of the entries to be false-positives.
for example:
1. !ENTRY org.eclipse.osgi 2 1 2011-02-16 16:12:37.432
!MESSAGE NLS unused message: the_argument_0_is_not_valid in: org.eclipse.wst.jsdt.debug.internal.ui.messages
that message is being used int JavaScriptConnectTab
2. !ENTRY org.eclipse.osgi 2 1 2011-02-16 16:12:37.354
!MESSAGE NLS unused message: add_script_load_bp in: org.eclipse.wst.jsdt.debug.internal.ui.messages
that message is being used in AddScriptLoadBrekapointAction
3. !ENTRY org.eclipse.osgi 2 1 2011-02-16 16:12:37.370
!MESSAGE NLS unused message: bp_hit_count in: org.eclipse.wst.jsdt.debug.internal.ui.messages
that message is used in JavaScriptModelPresentation
there are many more of them, and I do not know why they are being reported as not being used.
I applied the first patch to HEAD. applied the patch to 3.2.4 as well |
Created attachment 189130 [details] .log file Build: wtp-M-3.2.3-20110211193042.zip After adding the "Editing and validating XML files" example project to the workspace, many "NLS unused message" messages are logged into the .log file EVERY TIME we launch Eclipse. This will fill up the .log file quickly. The messages are not related to the NL packs. They mean there is a string in the properties file but there is no corresponding key in the messages Java file. This suggests a mismatch between the Java file where the keys are defined and the property file.