Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 337209

Summary: [preferences][JUnit] 'Show newly launched test in all JUnit views' not stored
Product: [Eclipse Project] JDT Reporter: Dani Megert <daniel_megert>
Component: UIAssignee: Markus Keller <markus.kell.r>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 3.7   
Target Milestone: 3.7 M6   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Fix none

Description Dani Megert CLA 2011-02-15 08:38:10 EST 
3.7 M1 and HEAD.

1. enable  'Show newly launched test in all JUnit views'
2. exit
3. start
==> preference is lost.
Comment 1 Markus Keller CLA 2011-02-15 14:21:10 EST 
Created attachment 189037 [details]
Fix

Reading of the preference is correct. Storing of the preference is also correct (was only stored in AbstractUIPlugin#stop() -- I'm changing that to store it right from the preferences dialog).

So what was wrong then? JunitPreferenceInitializer opted for too much migration and cleansed all jdt.junit preferences on every restart. This was no big deal as long as there were no new UI preferences, but now it's definitely wrong.
Comment 2 Markus Keller CLA 2011-02-15 14:24:24 EST 
> Created attachment 189037 [details] [diff]
> Fix

The relevant fix was in JunitPreferenceInitializer.
Kudos for the incomplete patch go to bug 294650.

Fixed in HEAD.
Comment 3 Dani Megert CLA 2011-02-16 03:33:40 EST 
Verified in N20110215-2000.