Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 337203

Summary:	[refactoring] Cocoa only: Preview page in org.eclipse.ltk.ui.refactoring.RefactoringWizard shows no changes when empty space is clicked
Product:	[Eclipse Project] Platform	Reporter:	Anirudh Sasikumar <anirudhsasikumar>
Component:	SWT	Assignee:	Scott Kovatch <skovatch>
Status:	RESOLVED FIXED	QA Contact:
Severity:	minor
Priority:	P3	CC:	daniel_megert, skovatch
Version:	3.6.1
Target Milestone:	3.7 M6
Hardware:	Macintosh
OS:	Mac OS X
Whiteboard:

Description Anirudh Sasikumar

2011-02-15 07:19:44 EST

Build Identifier: 20100917-0705

In Cocoa, when the refactoring preview dialog shows a tree and changes underneath, clicking on the white or empty area next to the tree causes selection to be reset and changes to go away.

This is not the case in windows and it may not be immediately apparent to the user as to what happened.

Reproducible: Always

Steps to Reproduce:
1. Keep the cursor over a method name in a Java file.
2. Choose Source -> Change Method Signature.
3. Click on Add.
4. Click on Preview.
5. Click the white area under "Changes to be performed".

Notice that selection of the tree went away and "No preview available" is shown. This is unexpected and confusing.

Comment 1 Markus Keller

2011-02-15 11:47:15 EST

> Build Identifier: 20100917-0705
That's not an Eclipse SDK build, but I assume it's an M-build around 3.6.1.

In HEAD, this should have been fixed with bug 325230, but it looks like we have a regression here: In the ControlExample, I can deselect the selected item in an SWT.SINGLE Tree again.

Moving to SWT.

Comment 2 Scott Kovatch

2011-02-16 11:09:33 EST

This broke when I fixed bug 329840. I started using tableView:shouldSelectRow: instead of tableView:selectionIndexesForProposedSelection: because it was simpler to return a boolean than manipulate an NSIndexSet. But, tableView:shouldSelectRow: doesn't get called if the selection is about to be cleared and therefore we can't cancel it.

I have this fixed in Table and Tree but I want to double-check List this morning before checking it in.

Comment 3 Scott Kovatch

2011-02-16 11:20:03 EST

Fixed > 20110216.