Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 337196

Summary:

[DB] Use qualified table names in DB tests

Product:

[Modeling] EMF

Reporter:

Caspar D. <caspar_d>

Component:

cdo.db

Assignee:

Caspar D. <caspar_d>

Status:

CLOSED FIXED

QA Contact:

Severity:

enhancement

Priority:

CC:

saulius.tvarijonas

Version:

4.0

Flags:

stepper: review+

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

Bug Depends on:

337180

Bug Blocks:

Attachments:

Description	Flags
Patch	none

Description Caspar D.

2011-02-15 05:48:20 EST

This is just a matter of passing a key-value pair into the mappingStrategy
during setup. The advantage of qualified names is that we won't have to 
drop the database if some tests use dynamic packages whose elements' names
(and therefore the corresponding table names) collide.

This is in the same spirit as bug 337180 (but at the meta level instead of
the data level), and with the same goal: prepare the ground for a (hopefully)
significant performance improvement in test execution.

(I realize that here and there some test logic will have to be changed, 
particularly test-logic that has hardcoded the expected table name. This
stuff will have to be prefixed with "packageName_".)

Working on a patch.

Comment 1 Caspar D.

2011-02-15 06:06:24 EST

Created attachment 188984 [details]
Patch

Comment 2 Eike Stepper

2011-02-15 11:48:48 EST

I can not test it as the patch depends on bug 337180. But the code looks good. Go ahead...

Comment 3 Caspar D.

2011-02-15 22:34:37 EST

Committed to trunk, rev. 7088

Note: I missed one file in the patch (SQLQueryTest.java), but I
included in the commit.

Comment 4 Eike Stepper

2011-06-23 03:41:38 EDT

Available in R20110608-1407