Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 337165

Summary: Calling GEM when ISP not installed gives stuck dialog
Product: [Tools] PTP Reporter: Beth Tibbitts <beth>
Component: GEMAssignee: Project Inbox <ptp-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ahumphrey
Version: 4.0.5   
Target Milestone: ---   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:
Attachments:
Description Flags
This patch fixes the reported bug g.watson: iplog+

Description Beth Tibbitts CLA 2011-02-14 15:35:08 EST 
Call GEM (Formally Verify...)  which correctly reports that ISP is not installed.
But if you do it again, it has a dialog that gets stuck saying one analysis has not completed yet.

Dialog says "An analysis is correctly in progress.  Please wait until it completes or manually abort it before stating a new one."  This Dialog has an OK button but I get the Mac wait-icon (spinning beach ball) and I cannot kill it.

I also get this in the console:
Exception in thread "Thread-18" java.lang.NullPointerException
	at java.io.StringReader.<init>(StringReader.java:33)
	at java.util.Scanner.<init>(Scanner.java:665)
	at org.eclipse.ptp.gem.util.GemUtilities.getIspVersion(GemUtilities.java:416)
	at org.eclipse.ptp.gem.util.GemUtilities.hasCorrectIspVersion(GemUtilities.java:572)
	at org.eclipse.ptp.gem.util.GemUtilities.access$2(GemUtilities.java:571)
	at org.eclipse.ptp.gem.util.GemUtilities$2.run(GemUtilities.java:639)
2011-02-14 15:32:42.806 eclipse[13655:18923] *** -[NSConditionLock unlock]: lock (<NSConditionLock: 0x14780d370> '(null)') unlocked when not locked
2011-02-14 15:32:42.813 eclipse[13655:18923] *** Break on _NSLockError() to debug.

Assuming this is also true on 5.0
Comment 1 Alan Humphrey CLA 2011-02-15 17:48:23 EST 
Assigning to Alan Humphrey.
Comment 2 Alan Humphrey CLA 2011-02-15 17:51:47 EST 
Created attachment 189055 [details]
This patch fixes the reported bug

Will apply this patch to HEAD and ptp_4_0 branch.
Comment 3 Alan Humphrey CLA 2011-02-15 18:03:53 EST 
Applied patch to HEAD and ptp_4_0 branch.