Bugzilla – Full Text Bug Listing
| Summary: | does ws.explorer require org.eclipse.help.appserver? | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [WebTools] WTP Webservices | Reporter: | David Williams <david_williams> | ||||
| Component: | wst.ws | Assignee: | David Williams <david_williams> | ||||
| Status: | RESOLVED FIXED | QA Contact: | Keith Chong <keith.chong.ca> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | mahutch | ||||
| Version: | unspecified | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
David Williams
FYI, I opened bug 337073 to track the "change in 4.1 that breaks us" ... but not sure it is something they should fix on their end. Pretty sure this was always meant as "for the help system only" and not generally intended as "API-like" guarantee. FWIW, I am trying a local test build with resolution.devMode=true as a test. If it passes, it does mean the requirement is at least to some extent optional (though, of course, the function would probably not actually work without that bundle present ... perhaps there is a better, more general way to "invoke an app server" with less assumptions about who is actually providing it?). (In reply to comment #1) > > FWIW, I am trying a local test build with > resolution.devMode=true No effect. (I think I don't really know what reslution.devMode does ... but ... ) I did hack in a step in the build that snags org.eclipse.help.appserver from the 3.7 platform, plops it into place, and this allows the build and compile to complete. But webservices still wouldn't run, of course. I suspect it is more complicated than getting just that one appserver plugin, to make it run, and hopefully there's a better solution than packaging part of the 3.7 platform with WTP. There's a "public" build running I expect to finish by morning, though, work is still required, the compilelogs should be there (and looks like everything else is ok, still). Created attachment 188917 [details]
patch to remove dependency on "appserver" bundle
It appears this dependency was left in by accident, years ago. There was only one line of code that depended on it, and that method did not seem to be called from anywhere ... and the rest of the code seemed to be converted to use "JettyRunnable" ... and it, under the covers, softly uses org.eclipse.equinox.http.registry to get what services it needs. From what I can tell.
Unfortunately, my workspace, at the moment, isn't "runnable" so will see if I can test this patch ... unless ws team can tell by looking it is the right fix to make (even for WTP 3.3, running on 3.7, of course).
I could run from workspace (after some cleanup/closing) and the ws explorer seemed to launch fine without this dependency or line of code. I'm sure I didn't "run it through all its paces" but seems unlikely appServer.isStarted() would effect anything (since, presumably, we are not even using _that_ old tomcat app server. Let me know if something seems amiss. Thanks David for looking at this. We'll check this out and make any adjustments if necessary. |