Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 337060

Summary: Committing changes does not work
Product: z_Archived Reporter: Joerg Reichert <joerg83reichert>
Component: RemusAssignee: Tom Seidel <tom.seidel>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:
Attachments:
Description Flags
The complete eclipse log
none
mylyn/context/zip none

Description Joerg Reichert CLA 2011-02-13 08:44:46 EST 
Build Identifier: RCP-TRUNK-113

I created a shared folder on my Windows Vista system and have mounted it over the local network at my my MacOS system. In RIM I created a new local directory as remote connector linking to the mounted folder. Adding new files and folders and add it to the repository works so far. But committing an update on already shared file via the corresponding context menu entry has no effect. Making the commit on the containing folder leads to a NPE:

An internal error occurred during: "Committing 1 element(s)".
java.lang.NullPointerException

Reproducible: Always
Comment 1 Tom Seidel CLA 2011-02-13 10:40:32 EST 
Could you provide the full stack trace? Do you get the same error when synchronizing manually (Remote Synchronization->Synchronize)?
Comment 2 Joerg Reichert CLA 2011-02-13 10:49:57 EST 
Created attachment 188848 [details]
The complete eclipse log

The full .log file from workspace/.metadata (contains also some logs from beginning of January 2011)
Comment 3 Joerg Reichert CLA 2011-02-13 10:53:23 EST 
There is no Synchronize action in Remote Synchronization, only
 * commit
 * Add to Remote Repository (disabled, as already under control)
 * Replace with Repository content
 * Add to sync-ingnore
Comment 4 Tom Seidel CLA 2011-02-15 06:33:10 EST 
Ok, after some attempts to reproduce the problems I recognized that the events are not set visible propertly based on the selection (this causes the NPEs). The error results from a non-valid enablement of the context-menu: So for clarification the enabled-states must be implemented like follows:

* Synchronize:
1..n categories that are already on the remote repsoitory
* Commit
1..n categories that are already on the remote repository (the difference to synchronize is only that this action is without user-interaction)
* Share cateogry
1..n categories that are not shared to the repository (the parent element must be already present on the repository)
* Add to Remote repository
Delete this element. Adding single elements to the repository without the context of the parent element can be tricky, especially for repositories that have no hierarchical structure and does not accept all information types.
* Replace with repository content
1..n categories that are already on the remote repository.

Executung synchronization commands for single information units is currently out-of-scope due to its complexity. Focus is on synchronizing categories.

I'll start to implement these conditions to enable/disable certain remote commands.
Comment 5 Tom Seidel CLA 2011-02-19 09:17:43 EST 
Changed the behavior and implemented the missing functionalities:
Commit/Replace: All elements that are shared
Add to Repository: All elements that are not shared yet
Synchronize: All categories that are already shared.
Comment 6 Tom Seidel CLA 2011-02-19 09:17:47 EST 
Created attachment 189344 [details]
mylyn/context/zip