Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 337015

Summary:	removeListener() method in ModelElement class doesn't handle ImpliedElementProperty
Product:	z_Archived	Reporter:	Shenxue Zhou <shenxue.zhou>
Component:	Sapphire	Assignee:	Shenxue Zhou <shenxue.zhou>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	konstantin, ram.venkataswamy
Version:	unspecified
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:

Description Shenxue Zhou

2011-02-11 19:15:19 EST

This method in ModelElement class:
    public final void removeListener( final ModelPropertyListener listener,
                                     final ModelPath path )
    
doesn't handle ImpliedElementProperty. See Line 855.

Comment 1 Shenxue Zhou

2011-02-11 19:17:22 EST

I have a fix for it. Should I just go ahead to check it in?

Comment 2 Konstantin Komissarchik

2011-02-14 16:50:43 EST

Yes, please fix this.

Comment 3 Shenxue Zhou

2011-02-15 12:18:00 EST

Fix has been checked in.

Comment 4 Shenxue Zhou

2011-04-01 13:44:37 EDT

There is another instance of this inside removeListener() under branch of else if( head instanceof AllSiblingsSegment )

Comment 5 Shenxue Zhou

2011-04-01 13:49:11 EDT

I think I've got all those instances...

Comment 6 Ram Venkataswamy

2011-06-09 16:54:51 EDT

verified with build 393

Comment 7 Konstantin Komissarchik

2011-06-09 16:55:35 EDT

Closing.