Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 336961

Summary:

[tracepoints] selectTraceRecord() should not update the UI

Product:

[Tools] CDT

Reporter:

Marc Dumais <marc.dumais>

Component:

cdt-debug-dsf-gdb

Assignee:

Marc Khouzam <marc.khouzam>

Status:

RESOLVED FIXED

QA Contact:

Marc Khouzam <marc.khouzam>

Severity:

normal

Priority:

CC:

cdtdoug, marc.dumais, pawel.1.piech

Version:

8.0

Flags:

marc.khouzam: review? (fchouinard)

Target Milestone:

8.0

Hardware:

OS:

Linux

Whiteboard:

Attachments:

Description	Flags
proposed patch	marc.khouzam: iplog+
Updated patch to match HEAD	cdtdoug: iplog-

Description Marc Dumais

2011-02-11 11:21:02 EST

Build Identifier: M20100909-0800

We heavily use interface selectTraceRecord to fetch record information.   Since we don't do it from a user interaction, this call should not update the UI automatically.  

Reproducible: Always

Comment 1 Marc Dumais

2011-02-11 11:26:08 EST

Created attachment 188792 [details]
proposed patch

Comment 2 Francois Chouinard

2011-03-04 11:21:23 EST

Created attachment 190405 [details]
Updated patch to match HEAD

Same patch with minor adaptations to match HEAD.

Comment 3 Marc Khouzam

2011-04-25 09:55:28 EDT

Committed to HEAD.

Francois, when you have time, can you review?

Comment 4 CDT Genie

2011-04-25 10:23:13 EDT

*** cdt cvs genie on behalf of mkhouzam ***
Bug 336961: selectTraceRecord() should not update the UI because it can be used for background activities.

[*] GdbSelectPrevTraceRecordCommand.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/commands/GdbSelectPrevTraceRecordCommand.java?root=Tools_Project&r1=1.1&r2=1.2
[*] GdbSelectNextTraceRecordCommand.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/commands/GdbSelectNextTraceRecordCommand.java?root=Tools_Project&r1=1.1&r2=1.2

[*] GDBTraceControl_7_2.java 1.5 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBTraceControl_7_2.java?root=Tools_Project&r1=1.4&r2=1.5