Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 336905

Summary:

Confluence markup parser should handle table attributes, sub/super-script and escaped characters

Product:

z_Archived

Reporter:

Torkild Resheim <torkildr>

Component:

Mylyn

Assignee:

Torkild Resheim <torkildr>

Status:

CLOSED DUPLICATE

QA Contact:

David Green <greensopinion>

Severity:

enhancement

Priority:

Version:

unspecified

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

Bug Depends on:

336813

Bug Blocks:

Attachments:

Description	Flags
Patch for handling table attributes	none
mylyn/context/zip	none

Description Torkild Resheim

2011-02-11 03:27:26 EST

The Confluence language parser should handle table attributes in a way so that end result tables can be rendered similar to how it's done in Confluence itself. Basically we want a "1px solid #ddd border" around each cell and a #f0f0f0 background on table headers. Future implementations may improve on this and handle customised rendering of the tables.

The parser does not understand the markup for subscript and superscript. Nor is there support in Attributes for these text effects and consequently the XSL:FO/HTML generators cannot output the required code. See bug 336904.

Lastly escaped characters are not properly handled. Sometimes you can for instance see @\-@ in the generated XSL:FO. This markup should be handled as a plain dash character.

Comment 1 Torkild Resheim

2011-02-11 07:12:21 EST

(In reply to comment #0)
> The parser does not understand the markup for subscript and superscript. Nor is
> there support in Attributes for these text effects and consequently the
> XSL:FO/HTML generators cannot output the required code. See bug 336904.
On further inspection I found that the parser does indeed support these two glyph types so there appears to be no need to handle it further in ConfluenceLanguage.

Comment 2 David Green

2011-03-03 01:06:37 EST

Thanks for the bug.  For the table attributes, please provide an example of Confluence markup and the desired output.

Please file a separate bug for character escaping.

Comment 3 Torkild Resheim

2011-03-13 18:03:58 EDT

Hi David. I do have a small patch for that sets the table attributes as Confluence would. It depends on bug 336813.

Comment 4 David Green

2011-03-14 13:17:27 EDT

Great, feel free to attach the patch!

Comment 5 Torkild Resheim

2011-03-14 15:58:59 EDT

Created attachment 191162 [details]
Patch for handling table attributes

Oh... I was about to do that and apparently got distracted. Patch attached. Note that it also contains required changes from bug 336813.

Comment 6 David Green

2011-05-06 13:56:11 EDT

The patch looks good, but it's hard to verify without some JUnit tests.  Can you please provide some test cases?  Feel free to add methods to one of the existing @XslfoDocumentBuilderTest@  classes (see attached context).

Comment 7 David Green

2011-05-06 13:56:15 EDT

Created attachment 194968 [details]
mylyn/context/zip

Comment 8 Torkild Resheim

2011-05-10 03:34:33 EDT

(In reply to comment #6)
> The patch looks good, but it's hard to verify without some JUnit tests.  Can you
> please provide some test cases?  Feel free to add methods to one of the existing
> @XslfoDocumentBuilderTest@  classes (see attached context).
Sure. Will do.

Comment 9 Torkild Resheim

2012-12-05 05:28:55 EST

With Atlassian removing the wiki markup format in their Confluence 4.0 release I think continuing supporting Confluence is a waste of time. I'm resolving this as WONTFIX.

http://blogs.atlassian.com/2011/11/why-we-removed-wiki-markup-editor-in-confluence-4/

Comment 10 Torkild Resheim

2013-06-07 14:17:46 EDT

Reopening as this came up again.

Comment 11 Torkild Resheim

2013-06-07 14:18:34 EDT

Looks like a duplicate. I'm taking a look at the original issue.

*** This bug has been marked as a duplicate of bug 310611 ***