Bugzilla – Full Text Bug Listing
| Summary: | [Compatibility] Java editor context menu's OpaqueMenuItem causes editor to leak | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] e4 | Reporter: | Remy Suen <remy.suen> | ||||
| Component: | UI | Assignee: | Remy Suen <remy.suen> | ||||
| Status: | VERIFIED FIXED | QA Contact: | |||||
| Severity: | critical | ||||||
| Priority: | P3 | CC: | daniel_megert, pwebster | ||||
| Version: | 1.0 | ||||||
| Target Milestone: | 4.1 RC2 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Created attachment 189040 [details]
PopupMenuExtender patch v1
Patch to perform a deep unlinking operation of all model items from their corresponding contribution items so that the renderer no longer references them.
Paul, should the PopupMenuExtender have to do this? It feels to me like it should be handled by the renderer itself or that a deep call should be made when any model element and contribution item gets cleared from the renderer.
Remy, are we still mis-behaving here? PW (In reply to comment #2) > Remy, are we still mis-behaving here? The test still fails, yes. Released. PW Verified with I20110523-2200 on Windows XP. |
org.eclipse.jdt.ui.tests.leaks.JavaLeakTest's testJavaEditorContextMenu is failing. junit.framework.AssertionFailedError: Expected instance count: 0, actual: 1 Element 0 org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitEditor org.eclipse.ui.texteditor.TextEditorAction#fTextEditor -> org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitEditor@1321a4f org.eclipse.jface.action.ActionContributionItem#action -> org.eclipse.jdt.internal.ui.javaeditor.ClipboardOperationAction@261e08 java.util.HashMap$Entry#value -> org.eclipse.jface.action.ActionContributionItem(id=paste) java.util.HashMap$Entry[61] -> org.eclipse.e4.ui.model.application.ui.menu.impl.OpaqueMenuItemImpl@c7d60c (elementId: paste, tags: java.util.HashMap#table -> [Ljava.util.HashMap$Entry;@755470 org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRenderer#modelToContribution -> {org.eclipse.e4.ui.model.application.ui.menu.impl.MenuSeparatorImpl@1330af4 (elementId: reorgGroup, org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRenderer$1#this$0 -> org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRenderer@4621ac org.eclipse.e4.ui.services.internal.events.UIEventHandler#eventHandler -> org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRenderer$1@1ae74f5 org.eclipse.osgi.internal.serviceregistry.ServiceRegistrationImpl#service -> org.eclipse.e4.ui.services.internal.events.UIEventHandler@1f24908 java.lang.Object[160] -> {org.osgi.service.event.EventHandler}={event.topics=[org/eclipse/e4/ui/model/ui/UILabel/*], service java.util.ArrayList#elementData -> [Ljava.lang.Object;@9003aa org.eclipse.osgi.internal.serviceregistry.ServiceRegistry#allPublishedServices -> [{org.eclipse.osgi.framework.console.CommandProvider}={service.ranking=2147483647, service.id=2}, { org.eclipse.osgi.framework.internal.core.Framework#serviceRegistry -> org.eclipse.osgi.internal.serviceregistry.ServiceRegistry@187b9fe org.eclipse.osgi.framework.internal.core.AbstractBundle#framework -> org.eclipse.osgi.framework.internal.core.Framework@538793 org.eclipse.osgi.internal.loader.BundleLoader#bundle -> org.eclipse.jdt.ui.tests_3.7.0.qualifier [154] org.eclipse.osgi.internal.baseadaptor.DefaultClassLoader#delegate -> org.eclipse.jdt.ui.tests_3.7.0.qualifier org.eclipse.osgi.internal.baseadaptor.DefaultClassLoader -> org.eclipse.osgi.internal.baseadaptor.DefaultClassLoader@3e090f