Bug 336858

Comment 1 Benjamin Muskalla 2011-02-24 12:33:22 EST

Created attachment 189722 [details]
suggested fix

David, here is a suggested fix. Will take care of ensuring the right encoding is choosen by the build.

Comment 2 David Green 2011-02-24 14:01:24 EST

Comment on attachment 189722 [details]
suggested fix

Thanks Benjamin, patch applied.  Please resolve this defect if the CI build is running with all tests succeeding.

Comment 3 Benjamin Muskalla 2011-02-24 17:41:08 EST

Test is still red, need to investigate. Running the tests locally returns in a green testrun with the patch. Will investigate

Comment 4 David Green 2011-02-24 18:16:42 EST

consider encoding the characters in the unit test string constant (using \u syntax, eg: \u000A).  This will result in the correct character in the string without risk of client tooling errors.

Comment 5 Benjamin Muskalla 2011-02-24 18:17:15 EST

Created attachment 189761 [details]
patch

David, just attaching a new patch. I fear bugzilla somehow messes around with the encoding as my local patch has the correct char while the patch in bugzilla is broken. If it doesn't work, you may want to grab the offending char from http://en.wikipedia.org/wiki/%C3%9F and commit it directly.

Comment 6 Benjamin Muskalla 2011-02-24 18:21:58 EST

Created attachment 189762 [details]
patch

Good idea :)

Comment 7 David Green 2011-02-24 18:34:08 EST

committed, pushed.  Please resolve if/when the build succeeds.

Comment 8 Benjamin Muskalla 2011-02-24 18:50:58 EST

Tests still red, it seems you got the wrong character, see patch #3

<<<<<<< HEAD
		assertEquals("Ilja Preu\u00DF", node.getCompanyname());
=======
		assertEquals("Ilja Preu\u00C3\u0178", node.getCompanyname());
>>>>>>> 73c3634d8c7569ce184bdf09e99e9a5533372204

Comment 9 David Green 2011-02-25 14:18:23 EST

ack... take 4

Comment 10 Benjamin Muskalla 2011-02-25 14:29:06 EST

Yep, that did the trick. THanks