Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 336828

Summary: Contains a patch that extends Graphiti Patterns to support Delete, Remove and Direct Editing features as well as conditional palette item creation.
Product: [Modeling] Graphiti Reporter: Volker Wegert <eclipse>
Component: CoreAssignee: Michael Wenz <michael.wenz>
Status: CLOSED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: michael.wenz, tim.kaiser
Version: 0.8.0Flags: michael.wenz: indigo+
Target Milestone: 0.8.0   
Hardware: All   
OS: All   
Whiteboard: Indigo M6 theme_round_offs
Attachments:
Description Flags
proposed patch michael.wenz: iplog+

Description Volker Wegert CLA 2011-02-10 09:50:49 EST 
Build Identifier: Extend Patterns: Delete / Remove / Direct Editing / Conditional Palette Item

Patterns should be able to provide features for removing and deleting model objects as well as for the direct editing facility. In addition to this, it should be possible for a pattern _not_ to provide a palette item (this is currently not possible, every pattern always appears as palette item).

Reproducible: Always
Comment 1 Volker Wegert CLA 2011-02-10 09:51:19 EST 
Created attachment 188686 [details]
proposed patch
Comment 2 Michael Wenz CLA 2011-02-11 10:01:27 EST 
Volker,

thanks for providing this enhancement! From my point of view this looks very good, but I would like a colleague with more experience in the pattern area to have a final look next week before I submit this.

I would suggest only one minor change: the name of the method that prevents adding the palette entry might be irritating: what would you think of shouldAddToPalette() instead of isCreateFeatureImplemented()?

Michael
Comment 3 Volker Wegert CLA 2011-02-11 11:21:24 EST 
Michael,

thanks for the encouraging words. As for the renaming, that's fine with me - I usually try to stick to the isFoo/canBar scheme for boolean functions, but that's as arbitrary as anything...

  Volker
Comment 4 Michael Wenz CLA 2011-02-15 03:57:58 EST 
A colleague just had a look onto the fix, the stuff looks good from his point of view as well.

We shortly discussed the name of the method again and also found stciking to the is-scheme better. So I renamed the method once more to isPaletteApplicable.

I have just checked in the change to head. Thanks once more for the contribution!

Michael
Comment 5 Michael Wenz CLA 2011-06-24 09:10:54 EDT 
Part of Graphiti Indigo 0.8.0