Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 336769

Summary:	Eclemma menus/toolbars/coverage not working in 4.1
Product:	[Eclipse Project] e4	Reporter:	John Arthorne <john.arthorne>
Component:	UI	Assignee:	Project Inbox <e4.ui-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	pwebster, remy.suen
Version:	unspecified
Target Milestone:	4.1
Hardware:	PC
OS:	Windows 7
Whiteboard:
Bug Depends on:	336824, 337127
Bug Blocks:

Description John Arthorne

2011-02-09 17:13:01 EST

Build: 4.1 M5

I installed Eclemma 1.5.1 into Eclipse SDK 4.1 M5. There are some notable usability problems:

- Menu and toolbar contributions for Eclemma code coverage are missing. The only action/command that works is the editor context menu, from which I can open the Coverage Configurations menu

- Highlighting of coverage results in the editor is missing. I.e., if you run a coverage test, then click a file in the Coverage view, it normally colours the file with red/green to indicate coverage results. This colouring does not appear at all in 4.1 M5.

Net effect is that Eclemma is barely usable in 4.1. It's not clear to me if this is because Eclemma is using internals or if something isn't wired right in 4.1.

Comment 1 Remy Suen

2011-02-10 08:04:09 EST

(In reply to comment #0)
> - Menu and toolbar contributions for Eclemma code coverage are missing.

The toolbar should have a contribution and the 'Run' menu doesn't appear to be populated.

> The
> only action/command that works is the editor context menu, from which I can
> open the Coverage Configurations menu

I get the 'Coverage As' submenu in the context menu of the 'Package Explorer' view and in editors. I did notice that expanding this submenu pretty much hung my Eclipse for a couple of seconds. This doesn't happen in 3.x. Perhaps the bundle has already been loaded on startup in 3.x. John, did you get this hang?

> - Highlighting of coverage results in the editor is missing. I.e., if you run a
> coverage test, then click a file in the Coverage view, it normally colours the
> file with red/green to indicate coverage results. This colouring does not
> appear at all in 4.1 M5.

Not clear to me why this is broken. Perhaps they are using background colour checks or something and the colour calculation is off.

Comment 2 Remy Suen

2011-02-10 08:57:25 EST

(In reply to comment #1)
> (In reply to comment #0)
> > - Menu and toolbar contributions for Eclemma code coverage are missing.
> 
> The toolbar should have a contribution and the 'Run' menu doesn't appear to be
> populated.

In 3.x we have special code to extend the perspective with actionSet perspectiveExtensions.

Thread [Thread-2] (Suspended (breakpoint at line 1631 in Perspective))	
	Perspective.getPerspectiveExtensionActionSets() line: 1631	
	Perspective.restoreState() line: 1500	
	WorkbenchPage.restoreState(IMemento, IPerspectiveDescriptor) line: 3259	
	WorkbenchWindow.restoreState(IMemento, IPerspectiveDescriptor) line: 2225	
	Workbench.doRestoreState(IMemento, MultiStatus) line: 3683	
	Workbench.access$34(Workbench, IMemento, MultiStatus) line: 3625	
	Workbench$60.run() line: 2325	
	Workbench.runStartupWithProgress(int, Runnable) line: 2022	
	Workbench.restoreState(IMemento) line: 2323	
	Workbench.access$31(Workbench, IMemento) line: 2294	
	Workbench$54.run() line: 2140	
	SafeRunner.run(ISafeRunnable) line: 42	
	Workbench.restoreState() line: 2084	
	WorkbenchConfigurer.restoreState() line: 183	
	WorkbenchAdvisor$1.run() line: 781

Comment 3 Paul Webster

2011-02-10 09:00:06 EST

(In reply to comment #2)
> In 3.x we have special code to extend the perspective with actionSet
> perspectiveExtensions.
> 
> Thread [Thread-2] (Suspended (breakpoint at line 1631 in Perspective))    
>     Perspective.getPerspectiveExtensionActionSets() line: 1631    
>     Perspective.restoreState() line: 1500    


This code allows newly added actionSets (through perspectiveExtensions or always-on) to be merged into an already open perspective.

In theory, resetting your perspective in 4.1 should make the menus/toolbars appear.

PW

Comment 4 Remy Suen

2011-02-10 09:03:52 EST

(In reply to comment #3)
> In theory, resetting your perspective in 4.1 should make the menus/toolbars
> appear.

Sadly, this theory didn't seem to work. Deleting the deltas.xml did the trick though.

Just to be clear, the editor still doesn't highlight stuff.

Comment 5 Remy Suen

2011-02-10 09:27:33 EST

(In reply to comment #4)
> (In reply to comment #3)
> > In theory, resetting your perspective in 4.1 should make the menus/toolbars
> > appear.
> 
> Sadly, this theory didn't seem to work.

The cause has been identified and is being tracked by bug 336824.

Comment 6 John Arthorne

2011-02-10 10:42:16 EST

(In reply to comment #1)
> I get the 'Coverage As' submenu in the context menu of the 'Package Explorer'
> view and in editors. I did notice that expanding this submenu pretty much hung
> my Eclipse for a couple of seconds. This doesn't happen in 3.x. Perhaps the
> bundle has already been loaded on startup in 3.x. John, did you get this hang?

No, I didn't get this hang. I just restarted and tried it again, and it seemed to come up quickly.

Comment 7 Remy Suen

2011-02-14 09:46:54 EST

I thought the code coverage problem might be related to some issues with background colours or something so I changed my 4.1 theme to the classic theme but the problem persisted.

Comment 8 Remy Suen

2011-05-02 11:15:00 EDT

Code coverage works for me too now with I20110501-0200.

Thanks for testing EclEmma for us, John.