Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 336683

Summary: XslFoDocumentBuilder should allow for basic page styling
Product: z_Archived Reporter: Torkild Resheim <torkildr>
Component: MylynAssignee: Torkild Resheim <torkildr>
Status: RESOLVED FIXED QA Contact: David Green <greensopinion>
Severity: enhancement    
Priority: P3 Keywords: contributed
Version: unspecifiedFlags: greensopinion: iplog+
Target Milestone: 1.6.0   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Added basic page styling for XslFoDocumentBuilder
greensopinion: iplog+
mylyn/context/zip
none
mylyn/context/zip none

Description Torkild Resheim CLA 2011-02-09 03:42:12 EST
The XslFoDocumentBuilder is rather limited when it comes to page styling. At least some of the properties available should be supported so that users can define various page sizes, regions and margins.

We should allow for the following properties to be set on *simple-page-master*:
* page-width
* page-height
* margin-top
* margin-bottom
* margin-left
* margin-right
* reference-orientation

The following properties should be allowed on *region-body* inside of *simple-page-master*:
* margin-top
* margin-bottom
* margin-left
* margin-right

And we should allow for the following elements inside *region-body*
* region-before (extent & precedence)
* region-after (extent & precedence)
* region-start (extent & precedence)
* region-end (extent & precedence)
Comment 1 Torkild Resheim CLA 2011-02-10 06:05:19 EST
Created attachment 188674 [details]
Added basic page styling for XslFoDocumentBuilder

I missed the fact that page-width and page-height was already supported but some other changes have been done:
* Unless a value is assigned to the *pageMargins* member variable the existing "margin" value will be used on the *simple-page-master*. 
* Likewise if a value is assigned to *bodyMargins* member variable it will override the margin set by the automatic footer.
* Similar is handling of *region-after*. If the region has been specified it will override the automatically generated region.
* Other regions may also be specified.
Comment 2 Torkild Resheim CLA 2011-02-10 06:05:21 EST
Created attachment 188675 [details]
mylyn/context/zip
Comment 3 Torkild Resheim CLA 2011-06-01 07:46:08 EDT
I consider this issue fixed. The patch just needs to be applied if there is any interest.
Comment 4 David Green CLA 2011-08-05 16:37:16 EDT
Patch applied, thanks Torkild!
Comment 5 David Green CLA 2011-08-05 16:37:21 EDT
Created attachment 201023 [details]
mylyn/context/zip