Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 336673

Summary: Mechanism to contribute actions to maven repository view
Product: z_Archived Reporter: Igor Fedorenko <igor>
Component: m2eAssignee: Milos Kleint <mkleint>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: mkleint, pascal
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:

Description Igor Fedorenko CLA 2011-02-08 22:29:13 EST 
Maven repository view currently does not use standard eclipse mechanisms to contribute view actions. Instead, all actions are hardcoded in repository view implementation class. This makes it impossible to re-implement "Materialize Maven Project" action, which is implemented by classes that have been moved to new org.eclipse.m2e.scm bundle (as per bug 336555).
Comment 1 Milos Kleint CLA 2011-02-21 07:06:56 EST 
Igor, would it be enough to have only the materialize action declarative? I've looked at the other actions directly defined on the view and there would be a significant rewrite necessary to have them declarative as well.. I was thinking about having the materialize action declared via the usual popup menu extension point and the others added manually. If not possible, I would create a special purpose extension.
Comment 2 Igor Fedorenko CLA 2011-02-21 09:50:58 EST 
I agree, there is no need to reimplement all actions that are provided by the view itself. For the materialize action, ideally the view should allow all actions enabled for objects adaptable to org.eclipse.m2e.core.embedder.ArtifactKey. This is how materialize action is contributed to Package Explorer already, for example, so it would be nice if we could reuse the same contribution mechanism in Repositories View too.
Comment 3 Milos Kleint CLA 2011-02-25 04:35:34 EST 
http://git.eclipse.org/c/m2e/m2e-core.git/commit/?id=da00d17351966b1f8cb96edf598645161380c292

sort of not entirely the same as before, the materialize action comes first now. but in the context of other actions being always shown (even out of it's intended context) I guess it's ok.
Comment 4 Pascal Rapicault CLA 2011-03-04 15:09:04 EST 
.
Comment 5 Denis Roy CLA 2021-04-19 13:26:27 EDT 
Moved to https://github.com/eclipse-m2e/m2e-core/issues/