Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 336616

Summary: [Import/Export] WizardFileSystemResourceImportPage1 looses tree when navigating Back and Next
Product: [Eclipse Project] Platform Reporter: Vitali Yemialyanchyk <vyemialyanchyk>
Component: UIAssignee: Prakash Rangaraj <prakash>
Status: CLOSED WONTFIX QA Contact:
Severity: major    
Priority: P3 CC: daniel.rolka, pavel.vinogradov, prakash, vyemialyanchyk
Version: 3.7   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard: stalebug
Attachments:
Description Flags
Add clearing of visitedDirs to fileProvider none

Description Vitali Yemialyanchyk CLA 2011-02-08 08:53:32 EST 
Build Identifier: I20100608-0911

Import -> File System -> next -> select folder -> 
so possible to explore subtree
back -> next -> 
now does not possible to explore subtree - only one node available

Reproducible: Always

Steps to Reproduce:
1. Import -> File System -> next -> select folder
2. check - possible to explore subtree
3. back -> next -> 
4. now not possible to explore subtree
Comment 1 Prakash Rangaraj CLA 2011-03-23 07:08:33 EDT 
Not for this release. Will revisit later.
Comment 2 Pavel Vinogradov CLA 2011-05-09 17:47:08 EDT 
Hello.

I want to work on this bug as my first contribution to Eclipse.

I'm already used PluginSpy to find class org.eclipse.ui.internal.wizards.datatransfer.WizardFileSystemResourceImportPage1
which represend this dialog.

I will provide patch (when i fix this bug) and will hope on review.
Comment 3 Pavel Vinogradov CLA 2011-05-15 13:12:03 EDT 
Created attachment 195668 [details]
Add clearing of visitedDirs to fileProvider

Problem was in 'private FileSystemStructureProvider fileSystemStructureProvider', which remember visited directories and was cleaned only in function updateFromSourceField().

I'm add explicit visited dirs clean to function 'protected void resetSelection()'

After this patch fileProvider clean in function updateFromSourceField() maybe deprecated.
Comment 4 Pavel Vinogradov CLA 2011-12-01 01:01:39 EST 
Prakash G.R. can you revisit it for next release?
Comment 5 Daniel Rolka CLA 2013-09-25 11:53:15 EDT 
(In reply to Pavel Vinogradov from comment #4)
> Prakash G.R. can you revisit it for next release?

(In reply to Pavel Vinogradov from comment #3)
> Created attachment 195668 [details]
> Add clearing of visitedDirs to fileProvider
> 
> Problem was in 'private FileSystemStructureProvider
> fileSystemStructureProvider', which remember visited directories and was
> cleaned only in function updateFromSourceField().
> 
> I'm add explicit visited dirs clean to function 'protected void
> resetSelection()'
> 
> After this patch fileProvider clean in function updateFromSourceField()
> maybe deprecated.


Thanks for the provided patch. It partially solves the issue since the user is able to modify the tree after the '3. back -> next ->' step however the previous selection is lost what is incompatible with the rest of fields on the second wizard page. I think we have to keep selection and allow the user to modify the previously selected directory.

If you would like to prepare the updated patch for the issue please sign your CLA agreement (http://www.eclipse.org/legal/CLA.php) and send the new version of patch to Gerrit for review (http://wiki.eclipse.org/Gerrit#Doing_Code_Reviews_with_Gerrit)

thanks for your help,
Daniel
Comment 6 Eclipse Genie CLA 2019-11-08 02:10:41 EST 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.