Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 336601

Summary:	Set buckminster.download.source and buckminster.convert.source true by default when using the IDE
Product:	z_Archived	Reporter:	Thomas Hallgren <thomas>
Component:	Buckminster	Assignee:	buckminster.core-inbox <buckminster.core-inbox>
Status:	NEW ---	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	henrik.lindberg, michal.ruza, milesparker
Version:	unspecified
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:

Description Thomas Hallgren

2011-02-08 06:07:42 EST

The buckminster.download.source controls whether or not source bundles should be resolved and materialized by Buckminster. When working in an IDE, this is most often the desired behavior. The source boost productivity since you automatically get Javadoc API in tooltips and you can step into methods etc. when debugging. In a headless build however, the source is just excessive baggage.

The buckminster.convert.source triggers the insertion of the 'Eclipse-SourceBundle' manifest header if it's missing. This feature is important when downloading source bundles from Maven Central since they most commonly lack this header. Since the bundle is altered, this setting is false by default. I think it would make a lot of sense to have it default to true when materializing into an IDE.

I therefor propose that let buckminster.download.source and buckminster.convert.source be true by default unless Buckminster runs in headless mode.

Comment 1 Michal Ruzicka

2011-02-08 06:09:58 EST

+1

Comment 2 Henrik Lindberg

2011-02-08 11:55:14 EST

+1

Comment 3 Miles Parker

2011-04-12 20:54:22 EDT

+1 from me as well. But even with this option, I can't seem to collect all of the source for my IDE. I've tried setting the properties in both my local buckminster.properties and in the cquery itself, and that seems to obtain some of the source code but other bits are missing (in my case EMF)?? I've even tried creating a feature including that source, to no avail. It would be great to have to not worry about this at all...the more we can get to a situation where people can do a headless build and an IDE source setup with all of the same artifacts, the better.

Comment 4 Thomas Hallgren

2011-04-13 01:06:10 EDT

(In reply to comment #3)
> +1 from me as well. But even with this option, I can't seem to collect all of
> the source for my IDE. I've tried setting the properties in both my local
> buckminster.properties and in the cquery itself, and that seems to obtain some
> of the source code but other bits are missing (in my case EMF)?? I've even
> tried creating a feature including that source, to no avail. It would be great
> to have to not worry about this at all...the more we can get to a situation
> where people can do a headless build and an IDE source setup with all of the
> same artifacts, the better.

That sounds like material for a separate bugzilla.