Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 336547

Summary: [patch] internal OLE editors should be disabled by default
Product: [Eclipse Project] Platform Reporter: Shawn Minto <shawn.minto>
Component: UIAssignee: Platform-UI-Inbox <Platform-UI-Inbox>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: bokowski, daniel_megert, remy.suen
Version: 3.6   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
patch none

Description Shawn Minto CLA 2011-02-07 13:01:37 EST 
When an user opens a word or excel file in Eclipse, they are presented with an OLE editor that either doesn't work (a blank editor) or one that is limited and opens as dirty.  Users either then have to find the file on the system to open or realize that they can set the mapping for file extensions or disable the ability for in-place system editors.  As these editors do not work properly and therefore give a bad user experience, the default should be that in-place editing is not used. 

IWorkbenchPreferenceConstants.DISABLE_OPEN_EDITOR_IN_PLACE should by default be set to true.
Comment 1 Shawn Minto CLA 2011-02-07 13:03:40 EST 
Created attachment 188460 [details]
patch

Here is a patch that disables the use of in-place OLE by default.  Users and RCP app's can still enable this functionality if they would like it, but this should improve the overall experience when using Office documents inside of Eclipse.
Comment 2 Dani Megert CLA 2011-02-08 01:54:25 EST 
Yes, some stuff isn't working 100% but if the apps (like Word) are correctly installed then opening works fine (I don't even get the '*' with Word) and one can view and edit the document (that's for 3.7 M5 on Windows XP).

Disabling a feature that was there since 1.0 is a no go at this point, hence WONTFIX.

If there are really critical issues (like blank editor or broken behavior on Windows 7) then we should open separate bugs and see how they can be fixed.
Comment 3 Shawn Minto CLA 2011-02-08 10:20:25 EST 
When opening an Excel file, I got a blank editor that was marked dirty which is one of the problems that happens.  Is Platform UI the correct place to open bugs against this feature?
Comment 4 Dani Megert CLA 2011-02-08 10:33:16 EST 
(In reply to comment #3)
> When opening an Excel file, I got a blank editor that was marked dirty which is
> one of the problems that happens.  Is Platform UI the correct place to open
> bugs against this feature?
Platform SWT.