Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 336505

Summary:	[Model Explorer] Some actions provided in the Model Explorer don't use org.eclipse.ui.menus
Product:	[Modeling] Papyrus	Reporter:	Vincent Lorenzo <vincent.lorenzo>
Component:	Core	Assignee:	Vincent Lorenzo <vincent.lorenzo>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	0.8.0
Target Milestone:	0.8.0
Hardware:	PC
OS:	Windows XP
Whiteboard:
Bug Depends on:
Bug Blocks:	336518

Description Vincent Lorenzo

2011-02-07 09:04:01 EST

Some actions in the Model Explorer don't use org.eclipse.ui.menus ; 
Currently, the class DiagramActionProvider provides the following actions for a Diagram : 
 	- Rename
 	- Open in a New Tab / Open
 	- Close All Diagram
 	- Close 
 	- Delete
 	- Duplicate

Moreover the copy/paste/cut function are not correctly binding with the Eclipse Framework

Comment 1 Vincent Lorenzo

2011-02-08 05:32:09 EST

In R3939 : 
	The following actions are rewritten : 
		Rename for diagram
		Rename for NamedElement
		Open/Open In New Tab
		Close
		Close All

		oep.modelexplorer and oep.uml.modelexplorer are impacted.

Comment 2 Vincent Lorenzo

2011-02-08 05:35:17 EST

In R3939 : 
	the old classes which do these actions are now @deprecated
	the extension point schema/org.eclipse.papyrus.modelexplorer.actionHandler.exsd is deprecated too

Comment 3 Cedric Dumoulin

2011-02-08 05:43:17 EST

I think that we should provide common entry points for contextual menu, main menu, ...
By common, I mean that we should provide some 'contribution menu' with identical names in both explorer context menu, diagram context menu, Papyrus main menu ... This should allow to add command in all this menu, just with one declaration.

Furthermore, we should document that in a wiki page for example.

Comment 4 Vincent Lorenzo

2011-02-08 06:35:31 EST

In R3942 : remove unused dependency

Comment 5 Vincent Lorenzo

2011-02-08 06:45:09 EST

(In reply to comment #3)
 That you describe is something like the extensions points provided by GMF : contributionItemProvider. Why not, 
 but, we should be careful in order don't have the same problems that the GMF extension point. (commands which don't appear in the key preference pages, menus (toolbar, popup, menu), which don't appear in the perspective customization, current eclipse extension points, which can't insert their own commands in the GMF menus...

Comment 6 Vincent Lorenzo

2011-02-09 04:22:41 EST

In R3950 :   add a test in order avoid NPE, in OpenHandler

Comment 7 Vincent Lorenzo

2011-02-10 03:41:17 EST

In R3976 : Cut/Copy/Paste/Undo/Redo are rewritten with the Eclipse Framework.

Comment 8 Vincent Lorenzo

2011-07-11 04:40:50 EDT

This bug can be marked as closed