| Summary: | Memory Improvement: Share session log between SDOHelperContexts | ||||||
|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Blaise Doughan <blaise.doughan> | ||||
| Component: | Eclipselink | Assignee: | Nobody - feel free to take it <nobody> | ||||
| Status: | NEW --- | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | david.mccann | ||||
| Version: | unspecified | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Blaise Doughan
Each Session has an instance of DefaultSessionLog that we do not use in SDO. Any logging we currently do is done via the abstract session's singleton default log. We may be able to: 1) Modify abstract session to enable nulling out the default log for each session, i.e. modify setSessionLog to handle a null input arg. This will be tricky because each session is expected to have a defult log set and there are plenty of spots where it is lazy loaded. 2) Create a new log, say 'NullSessionLog', that we can set on the session - this log will do nothing when it is asked to log. Not sure how difficult this will be, but seems like it could work. Created attachment 188955 [details]
Proposed fix.
Lazy loaded static NullSessionLog instance on AbstractSessionLog. In XMLContext constructor instead of calling session.setLogLevel(Session.OFF), we call session.setSessionLog(AbstractSession.getNullSessionLog()).
The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink |