Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 336267

Summary: [FieldAssist] ControlDecoration perfroms unnecessary redraws
Product: [Eclipse Project] Platform Reporter: ben <benjamin.leipold>
Component: UIAssignee: Platform UI Triaged <platform-ui-triaged>
Status: CLOSED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: prakash, remy.suen, vciontu
Version: 3.6.1   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard: stalebug
Attachments:
Description Flags
Possible fix
none
Diff of ControlDecoration none

Description ben CLA 2011-02-03 13:13:49 EST 
Build Identifier: 20100917-0705

Introduced by the fix of bug 212501, ControlDecoration performs unnecessary redraws in upadte(), since there are no checks whether there is really a need for redraws. For example, if show() or hide() are called, update() is called to and forces a redraw. Even if the decorated control is not visible.
In most circumstances that does not matter. But if the UI contains a widget that performs performance-intensive redraws, that might be of interest (like in my case). Since the redraw is triggered on the shell, any visible widget intersecting the area to be redrawn is notified via a paint event.

Reproducible: Always
Comment 1 ben CLA 2011-02-03 13:17:05 EST 
Created attachment 188260 [details]
Possible fix

I have tested the changes using the snippet from bug 212501 and it seems to work.
Comment 2 Susan McCourt CLA 2011-12-01 11:40:03 EST 
Can you please attach a patch/diff (rather than the entire .java file) so that I can take a look at what you've changed?
Comment 3 ben CLA 2011-12-16 04:58:50 EST 
Created attachment 208483 [details]
Diff of ControlDecoration

Here is the diff against eclipse version 3.5.2.
Comment 4 Lars Vogel CLA 2019-11-14 03:49:40 EST 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

If the bug is still relevant, please remove the "stalebug" whiteboard tag.