Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 336255

Summary:

Feature Request: Prepare ChangeLog for git

Product:

[Tools] Linux Tools

Reporter:

Ben Konrath <ben>

Component:

ChangeLog

Assignee:

Jeff Johnston <jjohnstn>

Status:

RESOLVED FIXED

QA Contact:

Severity:

enhancement

Priority:

CC:

caniszczyk, jjohnstn, linux.changelog-inbox, overholt

Version:

unspecified

Target Milestone:

1.0

Hardware:

OS:

Linux

Whiteboard:

Bug Depends on:

Bug Blocks:

336359

Attachments:

Description	Flags
245d40227b3fa59750bc55d28f0945a7823ce69c.patch	none
ChangeLog now gets the project root by querying IProject instead of assuming its the same directory as the workspace.	none
ChangeLog plugin.xml patch following yesterday's patch - added project persistent properties specifically for Egit	none
Added a line to set the currentProject field.	none

Description Ben Konrath

2011-02-03 11:16:42 EST

Build Identifier: 

I'm currently using "moap changelog prepare" to create ChangeLog entries while using git but I'd like to stay in Eclipse for this. Moap creates entries for any file that is staged to be committed in the git repository and I think that's the right way to do it. The alternative would be to add every file has been changed (staged or not) but I don't think that would be the correct behaviour. Thanks.   

Reproducible: Always

Comment 1 Andrew Overholt

2011-02-03 11:19:31 EST

Jeff, do you think we could do this for 0.8?  CCing Chris in case we need EGit or JGit advice.

Comment 2 Chris Aniszczyk

2011-02-03 11:24:24 EST

Let me know what you need to do.

Comment 3 Chris Aniszczyk

2011-06-14 16:53:34 EDT

Created attachment 197980 [details]
245d40227b3fa59750bc55d28f0945a7823ce69c.patch

Here's a patch that starts the work. The main problem with supporting EGit stems for supporting resources outside the workspace.

Comment 4 Ken Leung

2011-06-27 15:24:10 EDT

Created attachment 198678 [details]
ChangeLog now gets the project root by querying IProject instead of assuming its the same directory as the workspace.

Comment 5 Ken Leung

2011-06-28 09:11:21 EDT

Created attachment 198720 [details]
ChangeLog plugin.xml patch following yesterday's patch - added project persistent properties specifically for Egit

Comment 6 Ken Leung

2011-06-28 10:34:20 EDT

Created attachment 198737 [details]
Added a line to set the currentProject field.

Comment 7 Jeff Johnston

2011-07-14 16:52:39 EDT

Comment on attachment 198720 [details]
ChangeLog plugin.xml patch following yesterday's patch - added project persistent properties specifically for Egit

Obsoleted by Chris' patch.

Comment 8 Jeff Johnston

2011-07-14 16:54:23 EDT

Comment on attachment 198737 [details]
Added a line to set the currentProject field.

Obsoleted by Chris' patch.

Comment 9 Jeff Johnston

2011-07-14 16:54:42 EDT

Comment on attachment 198678 [details]
ChangeLog now gets the project root by querying IProject instead of assuming its the same directory as the workspace.

Obsoleted by Chris' patch.

Comment 10 Jeff Johnston

2011-07-14 17:06:24 EDT

Patches checked into HEAD.

Comment 11 Jeff Johnston

2011-07-14 17:47:18 EDT

Comment on attachment 197980 [details]
245d40227b3fa59750bc55d28f0945a7823ce69c.patch

iplog not needed for committer.

Comment 12 Andrew Overholt

2011-08-15 14:35:03 EDT

Is this suitable for a bug-fix release (0.8.1) or should the Target Milestone be set to 0.9.0?

Comment 13 Jeff Johnston

2011-08-15 15:57:07 EDT

(In reply to comment #12)
> Is this suitable for a bug-fix release (0.8.1) or should the Target Milestone
> be set to 0.9.0?

Yes, since 0.8.1 will be SR1 and the fixes for egit/jgit needed should be in SR1.

Comment 14 Jeff Johnston

2011-08-15 16:17:12 EDT

(In reply to comment #13)
> (In reply to comment #12)
> > Is this suitable for a bug-fix release (0.8.1) or should the Target Milestone
> > be set to 0.9.0?
> 
> Yes, since 0.8.1 will be SR1 and the fixes for egit/jgit needed should be in
> SR1.

Actually, I need to back-pedal here.  Since 0.8.1 is intended to be bug-fix-only, then this new feature should be moved to 0.9.0 which I have done.

Comment 15 Andrew Overholt

2011-08-24 16:47:10 EDT

Since an EGit release newer than 1.0.0 is required for this, we can't have it in 0.8.1 or 0.9.0 (yet).  If EGit contributes a release containing what this requires, we can add this back to our release.

Setting Target Milestone to 1.0 which will surely have the proper version of EGit.