Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 336195

Summary:	Error Dialog - "Show Error Log" Link should not contain <a>-Tags in translatable text
Product:	[Technology] Babel	Reporter:	Mico Micic <mico>
Component:	translations	Assignee:	Babel server inbox <babel.server-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	kitlo
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Mico Micic

2011-02-03 03:24:48 EST

Build Identifier: 20100917-0705

In org.eclipse.ui.internal.statushandlers.InternalDialg#createShowErrorLogLink() the link text "WorkbenchMessages.ErrorLogUtil_ShowErrorLogHyperlink" contains <a> tags. In the german translation the tags are missing and the link is shown as a simple text without the possibility to click on it.

Reproducible: Always

Comment 1 Dani Megert

2011-02-03 04:58:16 EST

> In the german translation the tags are missing and the link is shown
> as a simple text without the possibility to click on it.
That's a bug in the translation.

Comment 2 Thomas Schindl

2011-02-03 05:03:31 EST

Dani, I don't think this is a translation error I think the <a></a> should be really part of the code and not the .properties-File:

---------8<---------
link.setText("<a>" + WorkbenchMessages.ErrorLogUtil_ShowErrorLogHyperlink + "</a>");
---------8<---------

Comment 3 Mico Micic

2011-02-03 05:39:18 EST

(In reply to comment #2)
> Dani, I don't think this is a translation error I think the <a></a> should be
> really part of the code and not the .properties-File:
> 
> ---------8<---------
> link.setText("<a>" + WorkbenchMessages.ErrorLogUtil_ShowErrorLogHyperlink +
> "</a>");
> ---------8<---------

Thanks for the reply.

Comment 4 Kit Lo

2011-02-04 12:19:34 EST

I added the <a> tag around the German translation: 
http://babel.eclipse.org/babel/translate.php?project=eclipse&version=3.6&file=org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/messages.properties&string=ErrorLogUtil_ShowErrorLogHyperlink

Try again with the next Babel language packs.

Comment 5 Mico Micic

2011-02-04 15:50:27 EST

(In reply to comment #4)
> I added the <a> tag around the German translation: 
> http://babel.eclipse.org/babel/translate.php?project=eclipse&version=3.6&file=org.eclipse.ui.workbench/Eclipse
> UI/org/eclipse/ui/internal/messages.properties&string=ErrorLogUtil_ShowErrorLogHyperlink
> 
> Try again with the next Babel language packs.

I think this should have been fixed in the code, but OK, thank you!

Comment 6 Kit Lo

2011-02-04 17:19:07 EST

It was an oversight that the German translator omitted the <a> tag. At this point, I think it's better to fix the German translation. Moving the <a> tag to the code will break the translations in 30+ languages.