Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 336139

Summary: NPE thrown when trying to render a trim with unidentified elements
Product: [Eclipse Project] e4 Reporter: Remy Suen <remy.suen>
Component: UIAssignee: Remy Suen <remy.suen>
Status: VERIFIED FIXED QA Contact: Eric Moffatt <emoffatt>
Severity: normal    
Priority: P3 CC: hasachse
Version: 1.0   
Target Milestone: 4.1 M6   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
TrimBarLayout patch v1 none

Description Remy Suen CLA 2011-02-02 14:52:45 EST 
java.lang.NullPointerException
	at org.eclipse.e4.ui.workbench.renderers.swt.TrimBarLayout.isStatusLine(TrimBarLayout.java:245)
	at org.eclipse.e4.ui.workbench.renderers.swt.TrimBarLayout.computeSize(TrimBarLayout.java:146)
	at org.eclipse.e4.ui.workbench.renderers.swt.TrimBarLayout.access$0(TrimBarLayout.java:142)
	at org.eclipse.e4.ui.workbench.renderers.swt.TrimBarLayout$TrimLine.addControl(TrimBarLayout.java:36)
	at org.eclipse.e4.ui.workbench.renderers.swt.TrimBarLayout.computeSize(TrimBarLayout.java:104)
	at org.eclipse.swt.widgets.Composite.computeSize(Composite.java:233)
	at org.eclipse.e4.ui.workbench.renderers.swt.TrimmedPartLayout.layout(TrimmedPartLayout.java:120)
	at org.eclipse.swt.widgets.Composite.updateLayout(Composite.java:1263)
	at org.eclipse.swt.widgets.Composite.updateLayout(Composite.java:1249)
	at org.eclipse.swt.widgets.Composite.layout(Composite.java:664)
	at org.eclipse.swt.widgets.Composite.layout(Composite.java:622)
	at org.eclipse.e4.ui.workbench.renderers.swt.WBWRenderer.postProcess(WBWRenderer.java:585)
Comment 1 Remy Suen CLA 2011-02-03 07:43:30 EST 
Created attachment 188222 [details]
TrimBarLayout patch v1

An NPE was being thrown while trying to render a child of an MTrimBar that didn't have an element id set (it was 'null').
Comment 2 Remy Suen CLA 2011-02-03 07:44:31 EST 
(In reply to comment #1)
> Created attachment 188222 [details]
> TrimBarLayout patch v1

Fix and test released to CVS HEAD.
Comment 3 Remy Suen CLA 2011-02-23 08:21:32 EST 
*** Bug 337890 has been marked as a duplicate of this bug. ***
Comment 4 Remy Suen CLA 2011-03-09 09:53:54 EST 
Verified by source inspection with I20110307-2200.