Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 336089

Summary: New string in CSS3 can prevent the metamodel from loading
Product: [WebTools] WTP Source Editing Reporter: Nick Sandonato <nsand.dev>
Component: wst.cssAssignee: Nick Sandonato <nsand.dev>
Status: RESOLVED FIXED QA Contact: Nick Sandonato <nsand.dev>
Severity: major    
Priority: P3 CC: david_williams, neil.hauge, thatnitind
Version: 3.2.3Flags: nsand.dev: pmc_approved? (david_williams)
nsand.dev: pmc_approved? (raghunathan.srinivasan)
nsand.dev: pmc_approved? (naci.dai)
deboer: pmc_approved+
neil.hauge: pmc_approved+
nsand.dev: pmc_approved? (kaloyan)
thatnitind: review+
Target Milestone: 3.2.3   
Hardware: All   
OS: All   
Whiteboard: PMC_approved WI66962
Attachments:
Description Flags
patch none

Description Nick Sandonato CLA 2011-02-02 11:23:22 EST 
A new string that was introduced in the patch for CSS3 can cause CSS metamodel loading to fail when using another platform language.

This happens while loading the metalmodel based on the CSS3 profile. The exception occurs when checking the associated .properties file for the new string css3.stylesheet-def.description. Without the .properties file being translated, this will fail and cause a MissingResourceException and loading the profile will terminate. This will cause things like content assist to fail.

The strange thing is, the description that is set for this node is never actually displayed to the user. So I think we can either have no description or just embed the description into the markup.
Comment 1 Nick Sandonato CLA 2011-02-02 11:31:13 EST 
Created attachment 188160 [details]
patch

Embeds the string into the markup. This string is never made visible to the user in the first place.
Comment 2 Nick Sandonato CLA 2011-02-02 13:33:24 EST 
* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such.

CSS3 features cannot be used when using a different platform language.

* Is there a work-around? If so, why do you believe the work-around is insufficient?

No workaround.

* How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added?

Manually tested.

* Give a brief technical overview. Who has reviewed this fix?

When trying to load the translated string, a MissingResourceException is thrown since the updated .properties file has not been translated. To fix this, the new string used as a description is no longer externalized. This string was never made visible to users anyway, so the string was inlined.

Nitin has reviewed the fix.

* What is the risk associated with this fix?

Very low. The string is just now inlined.
Comment 3 Nick Sandonato CLA 2011-02-03 14:15:44 EST 
Code released with the blessing of the PMC.