Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 336079

Summary:

"Show Line Numbers" in compare editor context menu should be checked initially

Product:

[Eclipse Project] Platform

Reporter:

Markus Keller <markus.kell.r>

Component:

Compare

Assignee:

Tobias Melcher <tobias.melcher>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

eclipse.sprigogin, ma.becker, thomas.schulze.zur.wiesch, tobias.melcher, tomasz.zarna

Version:

3.7

Target Milestone:

4.6 M5

Hardware:

OS:

Windows 7

See Also:

https://git.eclipse.org/r/39809
https://git.eclipse.org/c/platform/eclipse.platform.team.git/commit/?id=fdf204490c8ccb4fe2970d2bec486c502f67fff8

Whiteboard:

Attachments:

Description	Flags
Screenshot showing the wrong checked state	none
patch	none

Description Markus Keller

2011-02-02 10:41:06 EST

I20110201-0800

Show line numbers in the text editor. Open a compare editor.
=> "Show Line Numbers" in compare editor context menu should now be checked initially, but it's not.

Has probably been broken with bug 266089.

Comment 1 Thomas Schulze zur Wiesch

2015-01-16 10:51:39 EST

Issue still exists in Eclipse 4.4 and 4.5. Any update on this?

Reproduce: enable "Show line numbers" in preferences, open compare editor for a source (e.g. local history), line numbers are shown, right-click in one of the editors -> Bug: menu entry "Show line numbers" is not checked

Best regards,
Thomas

Comment 2 Thomas Schulze zur Wiesch

2015-01-16 10:52:26 EST

Created attachment 250000 [details]
Screenshot showing the wrong checked state

Comment 3 Tobias Melcher

2015-01-17 07:17:58 EST

Created attachment 250011 [details]
patch

Sorry, I cannot upload the change to gerrit. I used following git url https://git.eclipse.org/r/platform/eclipse.platform.team.git. Is this not the correct one? I always get message "not authorized" when trying to push to gerrit.

Comment 4 Tobias Melcher

2015-01-17 07:34:34 EST

got it now. 

see https://git.eclipse.org/r/#/c/39809/

Comment 5 Matthias Becker

2015-02-18 02:33:30 EST

What's the status of this bug / patch? Will it go into the next Mars milestone?

Comment 6 Eclipse Genie

2015-12-24 21:25:09 EST

Gerrit change https://git.eclipse.org/r/39809 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.team.git/commit/?id=fdf204490c8ccb4fe2970d2bec486c502f67fff8

Comment 7 Sergey Prigogin

2015-12-24 21:26:46 EST

Thank you, Tobias, for the fix.