Bug 336056

Comment 1 Michael Gorovoy 2011-02-02 06:46:42 EST

Forwarding to Hugues for triage.

Comment 2 Hugues Malphettes 2011-02-03 08:22:50 EST

Jetty's DefaultServlet can only be deployed "directly" on a jetty itself.

The upside is that it has access to low level internal APIs of jetty which are necessary to serve static content efficiently.
The downside is: it assumes that it is deployed on jetty itself; not another servlet container and not the equinox http servlet.

I am quite sure that if we were to extend the DefaultServlet and override a few methods we should be able to reuse it.

Would you like to give it a try: extend the DefaultServlet, override the getServletContext() method to return the jetty object wrapped by equinox?

We could add this DefaultServletHttpEquinox to the jetty distribution if the 
experiment goes well.

Please let us know.

Comment 3 Julio Gonnet 2011-02-07 16:54:52 EST

Sure, I can give it a try - currently working on something else right now, but should be able to look at it sometime this week.

Comment 4 Hugues Malphettes 2011-05-09 23:22:14 EDT

I have tried to reproduce the bug and in fact it does not happen when using org.eclipse.jetty.osgi.httpservice to setup the HttpServiceServlet.

Nevertheless I have committed a small change in DefaultServlet to be able to override the part of the initialization of the DefaultServlet where the jetty context handler is located:
Extend the DefaultServlet and override:
    protected ContextHandler initContextHandler(ServletContext servletContext)

Will let you support custom logic to find the jetty contexthandler.

Here is the untested method for equinox's httpservice:
    /**
     * Compute the field _contextHandler.
     * In the case where the DefaultServlet is deployed on the HttpService it is very likely that
     * this method needs to be overwritten to unwrap the ServletContext until we reach
     * the original jetty's ContextHandler.Context
     * @return the jetty's ContextHandler for this servletContext
     */
	@Override
    protected ContextHandler initContextHandler(ServletContext servletContext)
    {
        ContextHandler.Context scontext=ContextHandler.getCurrentContext();
        if (scontext==null)
        {
        	if (servletContext instanceof ContextHandler.Context)
                return ((ContextHandler.Context)servletContext).getContextHandler();
        	else
        	{
        		ServletContext unwrapped = null;
    			try
    			{
    				java.lang.reflect.Field servletContextField = servletContext.getClass().getDeclaredField("servletContext");
    				servletContextField.setAccessible(true);
    				unwrapped = (ServletContext) servletContextField.get(servletContext);
    			}
    			catch (Throwable t)
    			{
            		throw new IllegalArgumentException("The servletContext " + servletContext + " " + 
                            servletContext.getClass().getName() + " is not " + ContextHandler.Context.class.getName() +
                            " and failed to unwrap a facade for it.", t);
    			}
				return super.initContextHandler(unwrapped);
        	}
        }
        else
            return scontext.getContextHandler();

    }