Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 335996

Summary:

[Dialogs] TrayDialog must not include tray when saving size

Product:

[Eclipse Project] Platform

Reporter:

Markus Keller <markus.kell.r>

Component:

Assignee:

Susan McCourt <susan>

Status:

VERIFIED FIXED

QA Contact:

Severity:

major

Priority:

CC:

daniel_megert, pawel.1.piech, remy.suen, susan

Version:

3.7

Target Milestone:

3.7 M6

Hardware:

All

OS:

All

Whiteboard:

Bug Depends on:

333684

Bug Blocks:

Attachments:

Description	Flags
Fix	none

Description Markus Keller

2011-02-01 12:55:47 EST

+++ This bug was initially created as a clone of Bug #333684 +++

I20110127-2034

The fix for 333684 broke the save/restore size feature in TrayDialogs and brought back bug 131978.

Please add a regression test for this.

Comment 1 Susan McCourt

2011-02-01 19:01:06 EST

sorry 'bout that.  Will look at it for M6.

Comment 2 Markus Keller

2011-02-14 12:18:21 EST

Created attachment 188918 [details]
Fix

This is really a pain. I think you should revert bug 333684 and fix the bug at the source, i.e. fix LaunchConfigurationsDialog#close() to not dispose resources as long as they are still referenced.

Comment 3 Markus Keller

2011-02-14 12:21:11 EST

> Created attachment 188918 [details]
> Fix

Pawel, could you release the LaunchConfigurationsDialog.java part of this?

Comment 4 Dani Megert

2011-02-15 03:43:46 EST

> I think you should revert bug 333684 and fix the bug at
> the source, i.e. fix LaunchConfigurationsDialog#close() to not dispose
> resources as long as they are still referenced.

+1.

Comment 5 Susan McCourt

2011-02-15 12:49:53 EST

Thanks, Markus.  I planned to revert the fix but never investigated the debug code.  Thanks for doing so.

I took the fix for the launch dialog and attached/reopened bug 333684.
This bug is fixed with the revert of the bad fix.  (I know better than to fix a specific problem with a framework solution, just wasn't thinking.)

Comment 6 Remy Suen

2011-02-15 13:08:33 EST

(In reply to comment #5)
> This bug is fixed with the revert of the bad fix.

The changes from Krzysztof for bug 336684 appears to have become collateral damage.

Comment 7 Markus Keller

2011-02-15 13:42:15 EST

> The changes from Krzysztof for bug 336684 appears to have become collateral
> damage.

Indeed (but not with my patch applied to TrayDialog 1.14)-:

Comment 8 Dani Megert

2011-02-16 04:39:55 EST

Fixed in HEAD and verified that this bug and bug 333684 are fixed.