Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 335982

Summary: Change the icon for Select Columns To Hide
Product: z_Archived Reporter: Vincent Lorenzo <vincent.lorenzo>
Component: EMF-FacetAssignee: Patrick Tessier <Patrick.Tessier>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P1 CC: emft.facet-inbox, gdupe
Version: unspecifiedFlags: gdupe: indigo+
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
an example of icon for Select Columns to hide
none
A second version for the same thing, in replacement of the first provided icon.
none
The second version of the icon for Select Columns To Hide, with a correct name.
Patrick.Tessier: iplog+
Change the icon used for the Select Columns To Hide action in the plugin.xml Patrick.Tessier: iplog+

Description Vincent Lorenzo CLA 2011-02-01 11:16:32 EST
The current icon for the action "Select Column To Hide" doesn't seem me very significative. Moreover, we would like use it for another action : "Create Table". 
Is it possible to replace the icon by another one, with the middle column in gray (for example)? An example of new icon is provided is the next attachment.
Comment 1 Vincent Lorenzo CLA 2011-02-01 11:18:39 EST
Created attachment 188059 [details]
an example of icon for Select Columns to hide

a new icon for "Select columns to hide"
Comment 2 Gregoire Dupe CLA 2011-02-02 04:22:37 EST
Hello Vincent,

Can you confirm that:
 - you  wrote 100% of the icon;
 - you have the right to contribute this icon to Eclipse ;
 - you contribute this icon under the EPL ?

Regards,
Grégoire
Comment 3 Vincent Lorenzo CLA 2011-02-02 11:16:17 EST
Created attachment 188157 [details]
A second version for the same thing, in replacement of the first provided icon.

A second version for the same thing, in replacement of the first provided icon.
Comment 4 Vincent Lorenzo CLA 2011-02-02 11:18:10 EST
No, I didn't write 100% of these icons, I modified the icon that you provided for the action Select Column To Hide. 
I suppose your icon is in EPL.
Yes, I want to contribute to this icon under the EPL.
Comment 5 Vincent Lorenzo CLA 2011-02-04 11:32:20 EST
(In reply to comment #4)
> No, I didn't write 100% of these icons, I modified the icon that you provided
> for the action Select Column To Hide.
> I suppose your icon is in EPL.
> Yes, I want to contribute to this icon under the EPL.
And  I have the right to contribute the code to Eclipse.
Comment 6 Gregoire Dupe CLA 2011-03-24 12:50:32 EDT
Comment on attachment 188157 [details]
A second version for the same thing, in replacement of the first provided icon.

Patrick,
Please, can you commit this patch?
Regards,
Gregoire
Comment 7 Vincent Lorenzo CLA 2011-03-29 02:58:20 EDT
Created attachment 192060 [details]
The second version of the icon for Select Columns To Hide, with a correct name.

(a) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.
Comment 8 Vincent Lorenzo CLA 2011-03-29 03:02:37 EDT
Created attachment 192061 [details]
Change the icon used for the Select Columns To Hide action in the plugin.xml

(a) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.
Comment 9 Gregoire Dupe CLA 2011-03-29 04:00:13 EDT
Patrick,

Please can you commit this contribution ?

Regards,
Gregoire
Comment 10 Patrick Tessier CLA 2011-03-29 10:53:43 EDT
Comment on attachment 192060 [details]
The second version of the icon for Select Columns To Hide, with a correct name.

Here is a contribution from one employee of CEA. The company has signed a Member Commiter Agreement. The contribution does not need a CQ. (http://dev.eclipse.org/mhonarc/lists/modeling-pmc/msg01997.html)
I've committed this contribution.
Committed revision 468.
Comment 11 Patrick Tessier CLA 2011-03-29 10:54:02 EDT
Comment on attachment 192061 [details]
Change the icon used for the Select Columns To Hide action in the plugin.xml

Here is a contribution from one employee of CEA. The company has signed a Member Commiter Agreement. The contribution does not need a CQ. (http://dev.eclipse.org/mhonarc/lists/modeling-pmc/msg01997.html)
I've committed this contribution.
Committed revision 468.
Comment 12 Gregoire Dupe CLA 2011-03-29 11:16:34 EDT
This can be marked as fixed.
Comment 13 Vincent Lorenzo CLA 2011-03-29 11:28:08 EDT
This bug can be marked as closed.