Bugzilla – Full Text Bug Listing
| Summary: | [IDE] Update BuildAction to use new Workspace Build Configurations API | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | James Blackburn <jamesblackburn+eclipse> | ||||
| Component: | IDE | Assignee: | Prakash Rangaraj <prakash> | ||||
| Status: | VERIFIED FIXED | QA Contact: | Prakash Rangaraj <prakash> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | bokowski, daniel_megert, prakash, pwebster | ||||
| Version: | 3.7 | Flags: | jamesblackburn+eclipse:
review?
(Szymon.Brandys) |
||||
| Target Milestone: | 3.7 M6 | ||||||
| Hardware: | PC | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Any chance this could be targetted for M6 for maximum exposure and so the CDT build action can leverage it? Yes, I'm looking this one for M6 only. James,
The patch looks good. But just one small thing. Usually, for the patches, copyright statement will be in the form or "Your Name, Company name - bug id/small desc of the patch". Would you like to attach an updated patch or just go with this?
> Usually, for the > patches, copyright statement will be in the form or "Your Name, Company name - > bug id/small desc of the patch". Would you like to attach an updated patch or > just go with this? FYI: It's good practice to add the credentials, see last paragraph in http://www.eclipse.org/legal/copyrightandlicensenotice.php. (In reply to comment #3) > The patch looks good. But just one small thing. Usually, for the > patches, copyright statement will be in the form or "Your Name, Company name - > bug id/small desc of the patch". Would you like to attach an updated patch or > just go with this? The copyright header is correct for this patch. This code has evolved over the last year and has had input from a couple developers here. Prakash, when you commit this to CVS, can you please add this bug number to the copyright header like suggested by Dani? Thanks! Patch 1 released to HEAD Verified in I20110307-2110 |
Created attachment 188044 [details] patch 1 The Workspace now supports building build configurations and their references. Currently BuildAction resolves project level references itself and builds the projects in turn. This patch updates BuildAction to delegate reference computation and building to the workspace which now has API for this. To do this I overrode WorkspaceAction's #runInBackground method. Other potential implementation that I tried didn't work: - Changing #invokeOperation -- this doesn't work as the method is invoked once per IResource - Overriding #createOperation -- doesn't directly produce a Job so can't mark the operation as belonging to the build family. #runInBackground is public API and callers expect it to run the BuildAction, so this seems to be the best place for this behaviour (e.g. CleanDialog calls this directly). Even though this is @noextend, there are some extenders (e.g. CDT). The patch preserves behaviour: shouldPerformResourcePruning() == true causes references to be built, shouldPerformResourcePruning() == false causes just the selected projects to be built.