Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 335949

Summary:

Mention IWorkbench's getModalDialogShellProvider() method in the porting guide

Product:

[Eclipse Project] Platform

Reporter:

Remy Suen <remy.suen>

Component:

Assignee:

Prakash Rangaraj <prakash>

Status:

VERIFIED FIXED

QA Contact:

Prakash Rangaraj <prakash>

Severity:

normal

Priority:

CC:

daniel_megert, prakash

Version:

3.7

Keywords:

Documentation

Target Milestone:

3.7 RC4

Flags:

daniel_megert: review+

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Patch v01	none
Patch v02	none

Description Remy Suen

2011-02-01 06:41:22 EST

This is a handy method (that was introduced in 3.6 for bug 231150) and should be mentioned in the porting guide.

Comment 1 Prakash Rangaraj

2011-05-04 05:32:15 EDT

Created attachment 194686 [details]
Patch v01

Comment 2 Prakash Rangaraj

2011-05-04 05:32:48 EDT

Remy/Dani,

     I need a +1 for the patch

Comment 3 Remy Suen

2011-05-09 11:05:46 EDT

(In reply to comment #2)
> Remy/Dani,
> 
>      I need a +1 for the patch

Since the method was added in 3.6, I think it should be added in the 3.6 porting guide instead of being in the 3.7 one.

Comment 4 Dani Megert

2011-05-10 02:08:47 EDT

(In reply to comment #3)
> Since the method was added in 3.6, I think it should be added in the 3.6
> porting guide instead of being in the 3.7 one.
+1.

Comment 5 Prakash Rangaraj

2011-05-31 06:43:26 EDT

Created attachment 196972 [details]
Patch v02

Patch v02

Comment 6 Prakash Rangaraj

2011-05-31 06:43:54 EDT

Dani/Remy,

    Need a +1 for patch v02

Comment 7 Dani Megert

2011-05-31 09:14:13 EDT

You don't need approval for doc changes.

The change looks good to me except for the copyright date, which should be "2009, 2011".

Comment 8 Oleg Besedin

2011-06-01 13:33:50 EDT

(In reply to comment #3)
> Since the method was added in 3.6, I think it should be added in the 3.6
> porting guide instead of being in the 3.7 one.

I guess better late then never :-). Patch applied to CVS Head with update copyright date mentioned by Dani.

Comment 9 Dani Megert

2011-06-03 04:27:57 EDT

Verified in I20110602-1051.