Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 335906

Summary:	Add more menu icons
Product:	[Tools] MAT	Reporter:	Andrew Johnson <andrew_johnson>
Component:	GUI	Assignee:	Andrew Johnson <andrew_johnson>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3
Version:	1.1
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:

Description Andrew Johnson

2011-01-31 16:42:07 EST

Menu icons make the product easier to use.

There are already quite a few menu icons, but some extras could be added.

For example context providers don't have icons. Adding them could be useful for table comparisons with set operations. The easiest way would be a URL getIcon() method on ContextProvider. This is an abstract method, so adding a dummy method returning null should be a compatible change. We could also add context icons to the class loader explorer

The Thread Details menu item on the context menu with the thread overview doesn't have an icon. This could be added to DetailResultProvider as a URL getIcon() method.

The HTML reports could also extract these icons.

Categories usually don't have icons. An exception is the merge_shortest_paths query. Perhaps categories with all queries having the same icon have that icon on the category. I'm not sure how to add an icon on a category in a compatible way if the subqueries have difference icons. E.g. for class refs the inbound and outbound queries have difference icons - but perhaps the category could also have the class icon.

Comment 1 Andrew Johnson

2011-02-04 10:18:36 EST

Existing Context Providers

Hash Entries
1.key
2.value

Big Drops in Dominator Tree
1.accumulation point?
2.dominator - use dominator icon?

Class Loader Explorer
1.Class Loader - use Class Loader object icon
2.Defined Classes - use Class icon (green C)
3.Class - use Class instance icon
4.Object instances - use Object instance icon

find_leaks (hidden)
1.Leak Suspect
2.Accumulation Point

Immediate Dominators
1.Objects
2.Dominated objects

Compare Tables query
1.Intersection - use new icon
2.Union - use new icon
3.Symmetric difference - use new icon
4.A minus B - use new icon
5.B minus A - use new icon


Existing detail results

Thread overview
1.Detail Result Provider

there is also a reference to both in TQuantize - but I am not sure how this is used.

We would then change QueryContextMenu and HtmlOutputter to use these icons.

Comment 2 Andrew Johnson

2011-02-06 14:21:12 EST

I've added the getIcon method to ContextProvider and DetailResultProvider and new context icons for the table comparison and icons for Class Loader explorer and a JDT icon for the open source file query.

The API Tooling says that the version number for report should be updated to match the @since 1.1 I added. We can update version numbers nearer release time.