Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 335803

Summary:	RecoveringCDOSessionConfiguratioImpl lacks sane defaults
Product:	[Modeling] EMF	Reporter:	Caspar D. <caspar_d>
Component:	cdo.core	Assignee:	Caspar D. <caspar_d>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	saulius.tvarijonas, stepper
Version:	4.0	Flags:	stepper: review+
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:

Description Caspar D.

2011-01-30 23:04:53 EST

Fiels heartBeatPeriod, heartBeatTimeout, connectorTimeout,
are not initialized, and so when such a session config
is used to instantiate a session, this session ends up
have '0' values for its corresponding config params.

Comment 1 Caspar D.

2011-01-30 23:05:40 EST

### Eclipse Workspace Patch 1.0
#P org.eclipse.emf.cdo.net4j
Index: src/org/eclipse/emf/cdo/internal/net4j/RecoveringCDOSessionConfigurationImpl.java
===================================================================
--- src/org/eclipse/emf/cdo/internal/net4j/RecoveringCDOSessionConfigurationImpl.java	(revision 6981)
+++ src/org/eclipse/emf/cdo/internal/net4j/RecoveringCDOSessionConfigurationImpl.java	(working copy)
@@ -24,13 +24,13 @@
 {
   private IManagedContainer container;
 
-  private boolean heartBeatEnabled;
+  private boolean heartBeatEnabled = false;
 
-  private long heartBeatPeriod;
+  private long heartBeatPeriod = 1000L;
 
-  private long heartBeatTimeout;
+  private long heartBeatTimeout = 5000L;
 
-  private long connectorTimeout;
+  private long connectorTimeout = 10000L;
 
   public RecoveringCDOSessionConfigurationImpl(IManagedContainer container)
   {

Comment 2 Caspar D.

2011-02-03 04:31:13 EST

Committed to trunk, rev. 7010

Comment 3 Eike Stepper

2011-06-23 03:40:21 EDT

Available in R20110608-1407