Bugzilla – Full Text Bug Listing
| Summary: | [Tree][CellEditor] Left Arrow key in cell editor makes TreeItem collapse | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [RT] RAP | Reporter: | Ralf Sternberg <rsternberg> | ||||
| Component: | JFace | Assignee: | Project Inbox <rap-inbox> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P2 | CC: | stefan.fink | ||||
| Version: | 1.4 | ||||||
| Target Milestone: | 1.4 RC1 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Ralf Sternberg
It can be reproduced on OS X 10.5.x with Firefox 3.6.x, Safari 5.0.x and Chrome 8.0.x. Arrow key up and down move the editor cursor to the first and last position of the text but also the selected line in the tree is moved accordingly. Actually all key presses are handled by the cell editor correctly but then propagated further on to the tree - which leads to the odd behaviour. It can be tested at: http://rap.eclipsesource.com/rapdemo/examples#Tree Created attachment 193575 [details]
Proposed patch
This patch stops the propagation of key press event in case of arrow keys and enabled text field. It is done in TextField that Text and CCombo widgets (used for cell editors) can both benefit from it. Are there any use case where this event have to be propagated?
In SWT the all key events are "consumed" by the Text widget and don't propagate to its parent. We should do it in the same way - not only for arrow keys. Fixed in CVS HEAD by stopping the propagation of keypress event in TextField.js. JS tests added. Just for the record - Tab keypress have to be propagated to the parent for correct focus handling. Changes are in CVS HEAD. |