Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 335778

Summary:

[quick assist] 'Pull Negation up' and 'Push Negation down' unnecessarily available

Product:

[Eclipse Project] JDT

Reporter:

Deepak Azad <deepakazad>

Component:

Assignee:

Deepak Azad <deepakazad>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

markus.kell.r, raksha.vasisht

Version:

3.7

Target Milestone:

3.7 M6

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
fix+tests	none

Description Deepak Azad

2011-01-29 14:33:23 EST

3.7 M5

------------------------------------------------------------
package snippet;

public class Snippet {
	void foo(Object a) {
		if (!(a instanceof String)) {

		}
	}
}
------------------------------------------------------------

- Select "!(a instanceof String)"
- Ctrl+1
- 'Pull Negation up' and 'Pull Negation down' are available, but they do not really do anything here...

Comment 1 Markus Keller

2011-02-03 10:13:57 EST

Should also not show up for simpler cases like:

        if (!b) { }

Comment 2 Deepak Azad

2011-02-21 06:25:59 EST

Created attachment 189399 [details]
fix+tests

Comment 3 Deepak Azad

2011-02-21 06:26:21 EST

Fixed in HEAD.

Comment 4 Raksha Vasisht

2011-03-07 12:18:52 EST

Verified for 3.6 M6.