Bugzilla – Full Text Bug Listing
| Summary: | We should not depend on E4XMIResource in our internal code | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Thomas Schindl <tom.schindl> | ||||
| Component: | UI | Assignee: | Platform UI Triaged <platform-ui-triaged> | ||||
| Status: | CLOSED WONTFIX | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | emoffatt, pwebster, remy.suen, stepper | ||||
| Version: | 4.1 | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | Mac OS X - Carbon (unsup.) | ||||||
| Whiteboard: | stalebug | ||||||
| Attachments: |
|
||||||
Skimmed the patch. I agree with the idea. Will take a closer look later this week. Thanks, Tom. I'm not sure if the parameter should be named 'local'. Internally in the E4XMIResource implementation we think of it as an "internal" id. The words "internal" and "local" have different connotations. To me "local" gives the impression that it is "shallow" and "temporary" whereas "internal" gives me the impression that it's "deep" and "permanent". Either the implementation's names should be changed or the interface needs to change its names. Can we take a look at this one for 4.2? (In reply to comment #3) > Can we take a look at this one for 4.2? Tom, I think we had an offline conversation about comment 2 but I don't remember what we decided...if anything? This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. If the bug is still relevant, please remove the stalebug whiteboard tag. |
Created attachment 187906 [details] patch We are currently blindly casting at various position to E4XMIResource which makes it impossible to load the workbench from another source. I think we should instead define a small SPI named IModelResource which holds the important methods we need.