Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 335743

Summary: Common Navigator edit action provider override too eager
Product: [WebTools] JSDT Reporter: Nitin Dahyabhai <thatnitind>
Component: GeneralAssignee: Nitin Dahyabhai <thatnitind>
Status: RESOLVED FIXED QA Contact: Nitin Dahyabhai <thatnitind>
Severity: normal    
Priority: P3 CC: david_williams, kaloyan, neil.hauge
Version: 3.2.3Flags: david_williams: pmc_approved+
thatnitind: pmc_approved? (raghunathan.srinivasan)
thatnitind: pmc_approved? (naci.dai)
thatnitind: pmc_approved? (deboer)
neil.hauge: pmc_approved+
kaloyan: pmc_approved+
Target Milestone: 3.2.3   
Hardware: All   
OS: All   
Whiteboard: PMC_approved WI65584
Attachments:
Description Flags
proposed patch, further restricts edit action provider override none

Description Nitin Dahyabhai CLA 2011-01-28 17:04:41 EST 
Created attachment 187887 [details]
proposed patch, further restricts edit action provider override

Bug 316796 modified the common navigator contributions to exclude the workspace root as a trigger, but it also made our action provider which overrides the default edit actions enabled on all resources.  This is causing issues in an adopter product where certain types of projects and closed projects no longer have the Cut/Copy/Paste/Delete actions, meaning the view can not be used to delete those projects at all.
Comment 1 Nitin Dahyabhai CLA 2011-01-28 17:08:58 EST 
* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 

Prevents common edit-type actions from being available in the common navigator views.

* Is there a work-around? If so, why do you believe the work-around is insufficient? 

Disable the JS content from the view, but it's not at all obvious that it's the cause.

* How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 

Ad-hoc tested by original reporter.

* Give a brief technical overview. Who has reviewed this fix? 

Restricts the override with our action provider to files of our content type.

* What is the risk associated with this fix? 

Low.
Comment 2 Nitin Dahyabhai CLA 2011-02-01 16:52:00 EST 
Released.