Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 335724

Summary: Regression: Changes to AbstractSession cause test failure
Product: z_Archived Reporter: Guy Pelletier <guy.pelletier>
Component: EclipselinkAssignee: Guy Pelletier <guy.pelletier>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: eclipselink.foundation-inbox
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Modifying test to pass on MySQL
none
Proposed changes none

Description Guy Pelletier CLA 2011-01-28 13:27:03 EST
org.eclipse.persistence.testing.tests.validation.BatchCommitTransactionExceptionTest started failing after revision 8888.

The changes to Abstract session were as follows (line 529)

// Ensure the transaction is rolledback on failure to commit.
try {
  accessor.rollbackTransaction(this);
} catch (Exception ingore) {}

If I removed this change, the test passes.
Comment 1 Guy Pelletier CLA 2011-01-28 13:34:14 EST
Created attachment 187861 [details]
Modifying test to pass on MySQL

MySql has been removed from the valid list of platforms for this test. Once this bug is corrected it will need to be re-added.
Comment 2 Guy Pelletier CLA 2011-01-28 14:01:16 EST
Created attachment 187865 [details]
Proposed changes

After a discussion with Andrei who reviewed the original transaction, it would apprear the offending block of code was intended to be removed and was committed by mistake. This patch removes that code and re-enables the test on MySQL.
Comment 3 Guy Pelletier CLA 2011-01-28 14:03:32 EST
Changes have been submitted.

Reviewed: Andrei Ilitchev

Tests: BatchCommitTransactionExceptionTest.java now passes on MySQL platform.
Comment 4 Eclipse Webmaster CLA 2022-06-09 10:08:58 EDT
The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink