Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 335713

Summary:

[server] GitFileStore.canPush() check can be omitted

Product:

[ECD] Orion

Reporter:

Tomasz Zarna <tomasz.zarna>

Component:

Client

Assignee:

Tomasz Zarna <tomasz.zarna>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

Version:

0.2

Target Milestone:

0.2

Hardware:

OS:

Windows XP

Whiteboard:

Bug Depends on:

Bug Blocks:

334094

Attachments:

Description	Flags
Fix v01	none
mylyn/context/zip	none

Description Tomasz Zarna

2011-01-28 12:48:51 EST

Similarly to Utils.isValidRemote from bug 335705, org.eclipse.orion.server.filesystem.git.GitFileStore.canPush() doesn't have to be called each time before doing a push. Instead, we could gracefully handle an eventual exception thrown when doing the push. This should save us some time when pushing to a valid/"pushable" repository.

Comment 1 Tomasz Zarna

2011-02-01 09:30:44 EST

Created attachment 188046 [details]
Fix v01

This fix won't give much boost when working with local repositories. However, for remote repos the improvement should be visible.

Comment 2 Tomasz Zarna

2011-02-01 09:30:46 EST

Created attachment 188047 [details]
mylyn/context/zip

Comment 3 Tomasz Zarna

2011-02-01 09:31:44 EST

(In reply to comment #1)
> [...] the improvement should be visible.

Especially when combined with bug 335705.

Comment 4 Tomasz Zarna

2011-02-03 10:50:29 EST

Fixed with 6bfbdf3b7b378e68aacbf687af7e961d370f6835.