Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 335657

Summary:

[call hierarchy] Refresh does not bring back removed roots

Product:

[Eclipse Project] JDT

Reporter:

Dani Megert <daniel_megert>

Component:

Assignee:

Martin Mathew <manju656>

Status:

VERIFIED FIXED

QA Contact:

Severity:

minor

Priority:

CC:

daniel_megert, deepakazad, markus.kell.r

Version:

3.7

Flags:

daniel_megert: review+

Target Milestone:

4.3 M7

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Patch.	daniel_megert: review+

Description Dani Megert

2011-01-28 02:57:17 EST

I20110127-2034.

1. open CH on foo
2. add bar via DnD
3. delete foo
4. refresh
==> foo is not coming back. However, deleting the last node (so that view is empty) and then refresh, brings back that node.

==> either never bring back a root or always bring them back.

Comment 1 Dani Megert

2011-01-28 03:07:55 EST

See also bug 335275.

Comment 2 Markus Keller

2011-01-28 06:17:30 EST

Discussed with Dani. A solution that avoids the inconsistencies with the last root and that brings us closer to the Search view behavior is this:

- Adding new roots always adds them to the current history entry and makes sure they show up in the CH view (even if they have been removed before).

- Removing a root only removes it from the view but does not touch history.

- Refresh of the whole view shows all roots again

Comment 3 Deepak Azad

2011-01-28 06:25:10 EST

(In reply to comment #2)
> - Removing a root only removes it from the view but does not touch history.
Makes sense. But a user must still be able to add (ctrl+drag) back a removed root.

Comment 4 Martin Mathew

2013-04-03 02:19:03 EDT

Consider the below scenario in CH view:
 -bar
     + foo
 -foo
     + bar
Delete the child node #foo from CH view. After deletion the CH view:
 -bar
 -foo
     + bar
Now refresh the CH view:
-bar
   +foo
The root node #foo is removed on refresh and the originally removed child node #foo is recovered, which looks wrong. After refresh the expected UI is:
 -bar
     + foo
 -foo
     + bar

Comment 5 Martin Mathew

2013-04-05 00:52:29 EDT

Created attachment 229361 [details]
Patch.

With this patch, after a node is removed (either child or parent), on refresh of the view the removed nodes are re-populated in the view. Remove does not touch the view history.
Adding a removed node again via drag and drop and then refresh will not show duplicate nodes.

Updating the view header label, when node is removed and filters are applied will be handled as a separate bug.

Comment 6 Dani Megert

2013-04-05 06:29:48 EDT

Thanks Manju!

Committed with http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=8715274aefc5cc4622fa79612694ce83063f2fad

Comment 7 Dani Megert

2013-05-23 07:10:49 EDT

Verified in I20130522-2000.