Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 335643

Summary: Session-less tests should be exercised as part of every suite
Product: [Tools] CDT Reporter: John Cortell <john.cortell>
Component: cdt-debug-dsf-gdbAssignee: John Cortell <john.cortell>
Status: RESOLVED FIXED QA Contact: Marc Khouzam <marc.khouzam>
Severity: normal    
Priority: P3 CC: cdtdoug, pawel.1.piech
Version: 8.0Flags: marc.khouzam: review+
Target Milestone: 8.0   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Solution john.cortell: iplog-

Description John Cortell CLA 2011-01-27 21:01:03 EST 
The vast majority of dsf-gdb tests involve a debug session, but there are a few that don't. Let's refer to the latter as the "session-less" tests.

These session-less tests are currently being neglected since they are not included in any of the suites that people normally run. These tests should run no matter which suite you run--e.g., whether you run AllSuites, or just the 7.2 ones; whether you run the remote tests or the local ones.

This patch achieves that, employing a trick to avoid having the session-less tests run multiple times when running a high-level suite (e.g., AllSuites). The trick was suggested to me by some crafty folks on the junit mailing list.
Comment 1 John Cortell CLA 2011-01-27 21:03:15 EST 
Created attachment 187794 [details]
Solution

Committed to HEAD. Mark, please review
Comment 2 John Cortell CLA 2011-01-27 21:04:39 EST 
Fixed
Comment 3 CDT Genie CLA 2011-01-27 21:23:02 EST 
*** cdt cvs genie on behalf of jcortell ***
Bug 335643: Session-less tests should be exercised as part of every suite

[*] Suite_Remote_7_0.java 1.4 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/tests/tests_7_0/Suite_Remote_7_0.java?root=Tools_Project&r1=1.3&r2=1.4
[*] Suite_7_0.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/tests/tests_7_0/Suite_7_0.java?root=Tools_Project&r1=1.2&r2=1.3

[*] Suite_6_8.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/tests/tests_6_8/Suite_6_8.java?root=Tools_Project&r1=1.2&r2=1.3
[*] Suite_Remote_6_8.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/tests/tests_6_8/Suite_Remote_6_8.java?root=Tools_Project&r1=1.2&r2=1.3

[+] OnceOnlySuite.java  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/tests/OnceOnlySuite.java?root=Tools_Project&revision=1.1&view=markup

[+] Suite_Sessionless_Tests.java  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/commands/Suite_Sessionless_Tests.java?root=Tools_Project&revision=1.1&view=markup
[-] AllTests.java  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/commands/AllTests.java?root=Tools_Project&view=markup

[*] Suite_7_2.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/tests/tests_7_2/Suite_7_2.java?root=Tools_Project&r1=1.1&r2=1.2
[*] Suite_Remote_7_2.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/tests/tests_7_2/Suite_Remote_7_2.java?root=Tools_Project&r1=1.1&r2=1.2

[*] Suite_7_1.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/tests/tests_7_1/Suite_7_1.java?root=Tools_Project&r1=1.1&r2=1.2
[*] Suite_Remote_7_1.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/tests/tests_7_1/Suite_Remote_7_1.java?root=Tools_Project&r1=1.1&r2=1.2

[*] Suite_Remote_6_6.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/tests/tests_6_6/Suite_Remote_6_6.java?root=Tools_Project&r1=1.2&r2=1.3
[*] Suite_6_6.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/tests/tests_6_6/Suite_6_6.java?root=Tools_Project&r1=1.2&r2=1.3

[*] Suite_Remote_6_7.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/tests/tests_6_7/Suite_Remote_6_7.java?root=Tools_Project&r1=1.2&r2=1.3
[*] Suite_6_7.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/tests/tests_6_7/Suite_6_7.java?root=Tools_Project&r1=1.2&r2=1.3
Comment 4 Marc Khouzam CLA 2011-01-27 21:24:19 EST 
Neat trick!

Would it be possible to move OnceOnlySuite.java to the tests.dsf.gdb.framework package?

Could we also add LaunchUtilsTest to the session-less suite?

Thanks!
Comment 5 John Cortell CLA 2011-01-27 21:27:32 EST 
Done