Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 335620

Summary: [RoR] Tab traversal between widgets broken
Product: [RT] Riena Reporter: Elias Volanakis <elias>
Component: UIAssignee: Elias Volanakis <elias>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: unspecified   
Target Milestone: 3.0.0   
Hardware: PC   
OS: Windows Vista   
Whiteboard:
Bug Depends on:    
Bug Blocks: 302893    

Description Elias Volanakis CLA 2011-01-27 16:06:50 EST
Using TAB to traverse between widgets does't work or works differently (i.e. different order) than in RCP.

It's important to fix this, as it affects usability in data entry heavy applications.
Comment 1 Ivan Furnadjiev CLA 2011-01-28 03:16:15 EST
Elias, just checked the SWT snippet 75 (http://dev.eclipse.org/viewcvs/index.cgi/%7Echeckout%7E/org.eclipse.swt.snippets/src/org/eclipse/swt/snippets/Snippet75.java) in RAP and it works 95% the same. What is broken in RAP? Which version of RAP are you using? Could you provide a snippet to demonstrate the difference?
Comment 2 Elias Volanakis CLA 2011-02-17 19:19:51 EST
Ivan,

this only happens in Riena. I.e. a regular view (tab working) when shown in Riena, will have the TAB not working. 

I've checked with firebug and there are no response / requests send when hitting TAB, so the issue must occur locally in the browser (ie clientside)

Do you have some pointers where the per-view tab ordering is configured in RWT? 

I suspect that because we are creating custom page and perspective content something may be different.

To reproduce it you have to install and configure Riena. You'll need the 1.4.M5 RAP target and the Riena code. This page has instructions: http://wiki.eclipse.org/Riena/RAP_Support    Alternatively, we could screenshare from my machine using skype and talk about a bit.
Comment 3 Elias Volanakis CLA 2011-02-17 20:36:29 EST
Ok, after some hunting I think I've found the problem in Riena. In our custom presentation we do this (bad!) :

public Control[] getTabList(final IPresentablePart 
  return new Control[] {};
}

Moving to Riena.
Comment 4 Elias Volanakis CLA 2011-02-18 01:37:21 EST
First fix in HEAD. Second half coming tomorrow.
Comment 5 Elias Volanakis CLA 2011-02-21 00:58:21 EST
Resolved.