Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 335526

Summary: ant.optional.junit requires runtime.compatibility
Product: [Eclipse Project] Platform Reporter: Jeff McAffer <jeffmcaffer>
Component: RelengAssignee: Platform-Releng-Inbox <platform-releng-inbox>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: daniel_megert, kim.moir, Michael_Rennie
Version: 3.7Flags: Michael_Rennie: review+
Target Milestone: 3.7 RC1   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
patch none

Description Jeff McAffer CLA 2011-01-26 18:47:54 EST 
to support the ant junit tasks we have a fragment (org.eclipse.ant.optional.junit) of the org.apache.ant bundle that adds a dependency on Junit. Unfortunately, this fragment also adds a dependency on org.eclipse.core.runtime.compatibility.  I'm not sure why it does this since ant and junit really should have nothing to do with Eclipse at all so should not be requiring code from eclipse.

The downside of having this dependency is that it drags in a whole raft of other bundles (e.g., all of core.runtime and friends) that are not needed for testing OSGi applications.

This bug is to explore the possibility of removing the dependency on core.runtime.compatibility.
Comment 1 Jeff McAffer CLA 2011-04-29 12:08:08 EDT 
Any thoughts on doing this change?  Might be late for 3.7 but I don't see why the dependency is needed.

Adding Kim since the bundle actually seems to be part of the testing framework.
Comment 2 Michael Rennie CLA 2011-05-02 12:55:47 EDT 
Scanning the list of Ant bugs about o.e.c.r.compatibility I came across bug 48184, bug 61602 and bug 87719 which looks like there should *not* be any dep on *.compatibility, and perhaps they just missed ant.junit.
Comment 3 Kim Moir CLA 2011-05-02 14:24:38 EDT 
Created attachment 194524 [details]
patch

I believe the requirement on runtime.compatibility is because this fragment is still in old school plugin format. I've attached a patch to change it to a proper OSGi bundle.  Please +1 if you'd like this change included in 3.7.
Comment 4 Michael Rennie CLA 2011-05-02 14:31:05 EDT 
+1 from me, I see no harm in the change, plus it was likely suppose to happen in one of the bugs I mentioned and just fell through the cracks until now.
Comment 5 Jeff McAffer CLA 2011-05-03 12:14:32 EDT 
+1.  Thanks.
Comment 6 Kim Moir CLA 2011-05-03 16:23:06 EDT 
Verified in test build and tagged for I-build.