Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 335431

Summary:	[Nattable] Cannot close the cell editor without calling commit()
Product:	z_Archived	Reporter:	Camille Letavernier <cletavernier>
Component:	EMF-Facet	Assignee:	Project Inbox <emft.facet-inbox>
Status:	CLOSED INVALID	QA Contact:
Severity:	major
Priority:	P3	CC:	gdupe, nicolas.guyomar
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Camille Letavernier

2011-01-26 05:04:14 EST

Build Identifier: I20101208-1300

When using custom IModelCellEditor which don't use the IModelCellEditHandler#commit() method, we cannot close the cell. It would be useful to have either a #close() method in org.eclipse.emf.facet.widgets.celleditors.IModelCellEditHandler, or an access to the org.eclipse.jface.viewers.CellEditor instance (For example by adding a parameter to IModelCellEditor#activateCell())

The reason why we don't use IModelCellEditHandler#commit() is that we use a different method to validate modifications, which would be redundant with #commit().

Reproducible: Always

Comment 1 Nicolas Guyomar

2011-02-07 05:31:35 EST

Hi Camille,

I do not understand the problem here.

Could you please attached to this bug an example of custom cell editor ?


It seems to me that if you do not use the IModelCellEditHandler#commit() method, then you just have to implement a close() method in your own code.

Our cellEditor composites use org.eclipse.emf.facet.widgets.celleditors.AbstractCellEditorComposite.close()

Regards,
Nicolas

Comment 2 Vincent Lorenzo

2011-02-21 07:33:44 EST

Resolved