Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 335394

Summary:

IllegalArgumentException when task attachments do not specify a URL

Product:

z_Archived

Reporter:

Thomas Ehrnhoefer <thomas.ehrnhoefer>

Component:

Mylyn

Assignee:

Thomas Ehrnhoefer <thomas.ehrnhoefer>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

steffen.pingel

Version:

unspecified

Keywords:

contributed

Target Milestone:

3.5

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
patch	none
mylyn/context/zip	none
patch v2 (+test)	steffen.pingel: iplog+
mylyn/context/zip	none

Description Thomas Ehrnhoefer

2011-01-25 17:31:01 EST

if a url is not specified, there are some problems in the UI :

if url is null: 
NPE at: @org.eclipse.mylyn.internal.tasks.ui.editors.AttachmentTableLabelProvider.getAttachmentId(AttachmentTableLabelProvider.java:133)@

if url is empty string:
IllegalArgumentException at: @at org.eclipse.mylyn.internal.tasks.ui.util.TasksUiMenus$1.run(TasksUiMenus.java:39)@

Comment 1 Thomas Ehrnhoefer

2011-01-25 17:33:58 EST

Created attachment 187586 [details]
patch

Comment 2 Thomas Ehrnhoefer

2011-01-25 17:33:59 EST

Created attachment 187587 [details]
mylyn/context/zip

Comment 3 Thomas Ehrnhoefer

2011-01-25 17:53:14 EST

Created attachment 187589 [details]
patch v2 (+test)

Comment 4 Thomas Ehrnhoefer

2011-01-25 17:53:16 EST

Created attachment 187590 [details]
mylyn/context/zip

Comment 5 Steffen Pingel

2011-01-25 19:39:56 EST

Thanks Thomas! I have applied the patch.