Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 335356

Summary: Changes for RAP/RCP single-sourced version of Memory Analyzer
Product: [Tools] MAT Reporter: Andrew Johnson <andrew_johnson>
Component: GUIAssignee: Project Inbox <mat.gui-inbox>
Status: NEW --- QA Contact:
Severity: enhancement    
Priority: P3 CC: elias
Version: 1.1   
Target Milestone: ---   
Hardware: All   
OS: All   
URL: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=4723
Whiteboard:
Bug Depends on:    
Bug Blocks: 262603    
Attachments:
Description Flags
Patch to existing MAT projects to enable RAP
none
Additional plugin projects for MAT for web enablement using RAP
none
Modify eclipse help system for use in RAP environment
none
RAP compatibility, forwarding UI calls from MAT to RAP none

Description Andrew Johnson CLA 2011-01-25 13:04:40 EST
CQ 4723 approved the changes from bug 262603 comment 1 for use in the Memory Analyzer project.

The approved code will be attached to this bug.
Comment 1 Andrew Johnson CLA 2011-01-25 13:10:07 EST
Created attachment 187550 [details]
Patch to existing MAT projects to enable RAP

Approved by CQ 4723
Comment 2 Andrew Johnson CLA 2011-01-25 13:13:47 EST
Created attachment 187552 [details]
Additional plugin projects for MAT for web enablement using RAP

Approved by CQ 4723

Hi Andrew:

I've been able to complete full review as part of the triage stage.

A couple of small changes that should be made before the content is checked in:

1.  ActionFactoryFacadeImpl.java contains the following 
 "About", "(c) Copyright Eclipse contributors and others 2000, 2009.  All
rights reserved.")

Copyright should not be assigned to Eclipse contributors (please note this
information is not contained in the header but included quite a distance down
in the file)

2. ...

Otherwise, this CQ is approved!

Cheers,
Sharon
Comment 3 Andrew Johnson CLA 2011-01-25 13:16:15 EST
Created attachment 187553 [details]
Modify eclipse help system for use in RAP environment

Approved by CQ 4723

Hi Andrew:

I've been able to complete full review as part of the triage stage.

A couple of small changes that should be made before the content is checked in:

1.  ...

2.  The patch contains the word 'hack', you may wish to adjust:-)

Otherwise, this CQ is approved!

Cheers,
Sharon
Comment 4 Andrew Johnson CLA 2011-01-25 13:17:30 EST
Created attachment 187554 [details]
RAP compatibility, forwarding UI calls from MAT to RAP

Approved by CQ 4723