Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 335310

Summary: RemoteServiceClientRegistration#properties field does not check for null
Product: [RT] ECF Reporter: Pavel Samolisov <samolisov>
Component: ecf.remoteservicesAssignee: ecf.core-inbox <ecf.core-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: samolisov, slewis
Version: 3.5.0   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
A result (only 2 if (properties == null) added none

Description Pavel Samolisov CLA 2011-01-25 08:45:10 EST
Created attachment 187516 [details]
A result (only 2 if (properties == null) added

In the RemoteServiceClientRegistration class's methods the dictionary property does not check for null, i.e. in methods getPropertyKeys or getProperty. This is leads to NPE when this class is used, i.e. for call via Proxy (in developed now XML-RPC provider).

I added this checkings, see the result. I can commit this stuff today evening (on MSK time) if you do not have any objections.
Comment 1 Scott Lewis CLA 2011-01-25 10:58:49 EST
Hi Pavel.  No objections from me...the null check change looks fine to me.  Please feel free to commit, push to master and resolve this bug.